After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 394075 - ffdemux disregards FlowReturn result of downstream pushing
ffdemux disregards FlowReturn result of downstream pushing
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-libav
0.10.2
Other Linux
: Normal normal
: 0.10.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-01-07 23:24 UTC by Mark Nauwelaerts
Modified: 2007-01-10 19:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch for checking downstream pushing result (2.68 KB, patch)
2007-01-07 23:27 UTC, Mark Nauwelaerts 		none Details | Review

Description Mark Nauwelaerts 2007-01-07 23:24:43 UTC 
ffdemux loop performs gst_pad_push without considering or reacting to any possible errors downstream, e.g. unlinked pads, etc
Comment 1 Mark Nauwelaerts 2007-01-07 23:27:14 UTC 
Created attachment 79692 [details] [review]
patch for checking downstream pushing result

[separated from patch in bug #392534]
- Make the ffdemux loop check the result of gst_pad_push and act accordingly
(e.g. ignore some unlinked pad, but give up when all unlinked)
Comment 2 Edward Hervey 2007-01-10 19:55:54 UTC 
Thanks, commited.

2007-01-10  Edward Hervey  <edward@fluendo.com>

        Patch by: Mark Nauwelaerts <manauw@skynet.be>

        * ext/ffmpeg/gstffmpegdemux.c: (gst_ffmpegdemux_perform_seek),
        (gst_ffmpegdemux_aggregated_flow), (gst_ffmpegdemux_get_stream),
        (gst_ffmpegdemux_loop):
        Check the aggregated return value of pushes downstream to figure out if
        we really need to stop the task or not.