GNOME Bugzilla – Bug 393709
Update docs: Spider Shuffle Variations
Last modified: 2007-01-19 09:40:35 UTC
There are currently three Spider games [.scm] in sol that only vary in their shuffle. This was necessary at the time (I am the culprit), because there were no game specific options. I have a patch to integrate the variations into one Spider. The only possible annoyances I can foresee, are that the scores will all be scored in one list, and that scores will not be imported from the previous un-integrated variations. I believe this introduces three translatable strings.
Created attachment 79579 [details] [review] Integrate Spider Variations Use this patch and delete 'spider_one_suit.scm' and 'spider_two_suit.scm'.
Thanks for the improvement. I have applied the patch to SVN, and will have to announce the string changes. Could you also submit a patch to update the documentation?
I'm reopening this bug, in the hope that the documentation will be automagically updated.
Created attachment 80168 [details] Documentation Just call me automagic. I integrated the documentation, did some reorganization, corrected some statements, used the option style from Klondike, and left the XML messy.
Created attachment 80169 [details] Documentation Fixed a mistake.
Thanks Aaron. (I've seen much messier XML in our documentation! ;) Replaced existing spider.xml with this one. Removed spider_one_suit.xml, spider_two_suit.xml I'd appreciate someone checking I've done the makefile changes properly and nothing is broken :)
Unfortunately this change has introduced a slight problem: Spiderette and Will O The Wisp, games based on Spider, now have useless Four Suits/Two Suits/One Suit options. I should have a patch for that soon.
Created attachment 80466 [details] [review] fix options in Spiderette and Will O' the Wisp
Created attachment 80469 [details] [review] remove documentation for One Suit and Two Suit variations from aisleriot.xml spider_one_suit.xml and spider_two_suit.xml shouldn't be mentioned in the help. I don't know what the consequences are if they are and I don't want to find out.
The consequences were Bug 398200. Fixed.