GNOME Bugzilla – Bug 393697
Theme packages should has their own mime type.
Last modified: 2007-03-02 02:02:52 UTC
Theme packages would be easier to install if they has their own mime type so people can double click them (right now, if users doble click the tar.gz they see the details of the .tar.gz trough the file-roller).
Created attachment 79580 [details] [review] Partial mime definition patch I patched Makefile.am almost blindly (copypasting from nautilus examples), it needs to be seriously reviewed.
Thanks Alberto. The patch looks reasonable, and I'll apply it after some testing.
Created attachment 79582 [details] [review] Mime type definition Improved version of the patch, fixes AC_CONFIG_FILES on configure.in
Created attachment 79584 [details] [review] Mime type definition Fixed inclusion of the new files in POTFILES.in
Created attachment 79699 [details] [review] Mime type definition fixes configure.in problem
Created attachment 79718 [details] [review] Mime type definition fixes problems in the .desktop file, the NoDisplay key is not needed and may cause problems
Closing, already applied
Created attachment 79789 [details] [review] Installer .gtp extension check. Adds .gtp extension check to the installer source code.
Comitted, thanks.
I really wish that the MIME type were under some class other than application/. A theme tarball is in fact, NOT an application. Maybe x-theme/gnome-theme-package or something would be better. I know application is basically a dumping ground for random crap and that's probably where most other themes have ended up putting their MIME types, but we should try to make it easier to do generics for things, rather than dumping everything we come up with, under application.
Tar.gz files aren't applications either, and uses application/x-compressed-tar (that's why I choosed applications) is there any MIME naming "best practices" documentation somewhere?
From RFC 2046, which defines the MIME type system 4.5. Application Media Type The "application" media type is to be used for discrete data which do not fit in any of the other categories, and particularly for data to be processed by some type of application program. This is information which must be processed by an application before it is viewable or usable by a user. Defining new media types is a bold move. However, as the MIME type isn't registered, it should be application/x-gnome-theme-package.
Created attachment 81250 [details] [review] Fixes on the suffix checks. Fixes the miss of checking ".gtp" suffix when remote installing (drag and drop from the browser) and replaces hardcore suffix checks with g_str_has_suffix from glib.
Created attachment 81251 [details] [review] Fixes on the suffix checks. Update the from the previous fix. Removing the length variable used to check the suffix.
2007-01-26 Thomas Wood <thos@gnome.org> Patch by: Alberto Ruiz <aruiz@synaptia.net> * gnome-theme-installer.c: (transfer_done_cb), (gnome_theme_install_from_uri): Fixes on the suffix checks.
Isn't it kind of broken to have one and only one mime type for a file? Why not <name>.gtp.tar.gz With a type expressing that it's: 1. a gzip compressed representation 2. of a tar archive 3. containing a gnome theme like application/x-gnome-theme; archive=application/x-tar; compression=application/x-gzip I mean why should the gnome theme spec contain mandated archiving or compression choices?