After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 391718 - Confusing indentation of threads
Confusing indentation of threads
Status: RESOLVED DUPLICATE of bug 248745
Product: evolution
Classification: Applications
Component: Do Not Use
2.10.x (obsolete)
Other All
: Normal minor
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2007-01-02 01:23 UTC by Anders Kaseorg
Modified: 2013-09-13 12:24 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18



Description Anders Kaseorg 2007-01-02 01:23:54 UTC
This may be a GTK bug; I don’t know for sure.

When Group By Threads is enabled, messages with children are displayed at (what appears to be) a greater indentation level than messages with no children, because of the extra space occupied by the expander triangles.  This is confusing, even when I know what’s going on.  Messages with no children should have extra space to replace the missing triangles.  Compare this actual screenshot:
  <http://foo.kaseorg.com/~anders/evolution-threads.png>
with this mockup of the desired appearance:
  <http://foo.kaseorg.com/~anders/evolution-threads-want.png>

Other information:
Comment 1 Srinivasa Ragavan 2007-05-02 04:50:19 UTC
Anders, this is due to the expander widget being inserted in mails with children. This is an evolution bug.
Comment 2 Matthew Barnes 2008-03-11 00:32:46 UTC
Bumping version to a stable release.
Comment 3 Tobias Mueller 2008-03-24 17:21:07 UTC
What would be a proper solution to this?

Maybe draw an "empty" expander widget for mails w/o children. Empty as in same dimensions.
Comment 4 Matthew Barnes 2008-03-24 17:53:23 UTC
It's likely an issue with ETree.  I don't think GtkTreeView has this problem.
Comment 5 Anders Kaseorg 2010-02-07 08:49:18 UTC
This patch fixes the problem for me:

diff --git a/widgets/table/e-cell-tree.c b/widgets/table/e-cell-tree.c
index 27698f8..3b834e9 100644
--- a/widgets/table/e-cell-tree.c
+++ b/widgets/table/e-cell-tree.c
@@ -110,12 +110,7 @@ offset_of_node (ETableModel *table_model, gint row)
 	ETreeModel *tree_model = e_cell_tree_get_tree_model(table_model, row);
 	ETreePath path = e_cell_tree_get_node(table_model, row);
 
-	if (visible_depth_of_node (table_model, row) > 0 ||
-	    e_tree_model_node_is_expandable(tree_model, path)) {
-		return (visible_depth_of_node(table_model, row) + 1) * INDENT_AMOUNT;
-	} else {
-		return 0;
-	}
+	return (visible_depth_of_node(table_model, row) + 1) * INDENT_AMOUNT;
 }
 
 /*
Comment 6 Anders Kaseorg 2010-06-20 11:32:17 UTC

*** This bug has been marked as a duplicate of bug 248745 ***