GNOME Bugzilla – Bug 391408
Misaligned contact cards when using evolution RTL
Last modified: 2008-01-24 11:14:24 UTC
In the contacts tab of evolution, the contact cards are misaligned. The labels (bold) should be on the right. This happens in RTL locales, like Arabic. The screenshot shows this. Other information:
Created attachment 79125 [details] Arabic Contacts screenshot
After close inspections, the labels are not actually bold, but they are those that appear in Arabic glyphs, the contact names and addresses are in latin characters.
Created attachment 102252 [details] [review] Fix the minicards This patch fixes the minicards to an acceptable level for RTL. Please review.
Created attachment 102253 [details] [review] Fix the minicards This patch fixes the minicards to an acceptable level for RTL. Please review. ---- One unrelated thing: Evolution sometimes keeps the old "addressbook library" in memory even after quitting it and restarting. Thereby my new changes are not seen until I restart the session. This makes me furious, how to stop this behaviour?
a) ChangeLog entry. b) do not create variables in the middle of the block, it should be at the beginning of the block. (it makes troubles for some compilers). c) I'm afraid this patch is not enough to work, for example see e-minicard-label.c:e_minicard_label_resize_children, there should be divided width in different order for RTL. What do you think?
Created attachment 103204 [details] [review] Improved patch. Here is an updated patch that does address the points above. It is satisfactory, but I wish I could align the fields to the right. I tried setting the "justification" property to GTK_JUSTIFY_RIGHT , with no success
Hm, I do not see how to do that either. Doing this by hand in e_minicard_label_reflow is not the right way, and extending e-text can be a bit complicated. Btw, I do not see that attribute used there, so if you want to play with this a bit more and fix it (in widgets/text/e-text.c), then you can. Otherwise you can commit this, but be careful, the source has been changed recently, so it doesn't apply smoothly, and do not break new logic there (if not sure then attach new patch here, I can review).
Created attachment 103519 [details] [review] modified patch from Djihed Afifi had to tweak Djihed Afifi's patch to apply on SVN trunk. Needs a review since Milan also had some changes in the same part of the code earlier.. [The logic is kinda okay, but I'm not sure how it'd look on screen]
I'll review when I get home this evening (GMT). Thanks Suman.
Build fails. I'll do it when that is fixed. mail-session.c: In function 'class_init': mail-session.c:121: error: 'CamelSessionClass' has no member named 'lookup_addressbook' mail-session.c: In function 'mail_session_set_junk_headers': mail-session.c:788: warning: implicit declaration of function 'camel_session_set_junk_headers' make[3]: *** [mail-session.lo] Error 1 make[3]: Leaving directory `/media/debian/jhbuild/checkout/evolution/mail'
DJihed, you have to update Evolution-data-server and try this.
Tested and committed, thanks Suman, Srinivasa, Milan.