After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 391179 - font selection dialog needs color option
font selection dialog needs color option
Status: RESOLVED OBSOLETE
Product: gtk+
Classification: Platform
Component: Widget: GtkFontChooser
2.10.x
Other All
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2006-12-31 03:04 UTC by Blake Madden
Modified: 2018-04-15 00:07 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
Add _set_select_color and _set_color (6.67 KB, patch)
2008-11-07 18:44 UTC, Christian Dywan
none Details | Review

Description Blake Madden 2006-12-31 03:04:48 UTC
The font selection dialog should have a font color option added to it where the user can select the color for their font.  This is what Windows does and can be fairly useful.
Comment 1 Christian Dywan 2008-10-29 16:00:13 UTC
The question is, where is that colour going to show up? I see how it might be useful to select together with a font, but generally the font as such doesn't include colour information.

You, or anyone interested, might come up with a more concrete use case, to see how the integration might look like.
Comment 2 Behdad Esfahbod 2008-10-29 17:27:38 UTC
Agreed.  Well, the caller can set an option that it also accepts a color, and set a current color.  Later it can fetch whether the color was changed and the chosen color.
Comment 3 Christian Dywan 2008-11-07 18:44:56 UTC
Created attachment 122199 [details] [review]
Add _set_select_color and _set_color

This is an attempt at adding a colour button to the font selection and functions to enable it and set and retrieve the colour.

No properties yet, and I reused the fontsel->pixels_button and fontsel->points_button to avoid a private structure. If you like the idea I can add properties, and if you prefer that, also add a private, if the workaround is too ugly.
Comment 4 Matthias Clasen 2018-02-10 04:58:41 UTC
We're moving to gitlab! As part of this move, we are moving bugs to NEEDINFO if they haven't seen activity in more than a year. If this issue is still important to you and still relevant with GTK+ 3.22 or master, please reopen it and we will migrate it to gitlab.
Comment 5 Matthias Clasen 2018-04-15 00:07:59 UTC
As announced a while ago, we are migrating to gitlab, and bugs that haven't seen activity in the last year or so will be not be migrated, but closed out in bugzilla.

If this bug is still relevant to you, you can open a new issue describing the symptoms and how to reproduce it with gtk 3.22.x or master in gitlab:

https://gitlab.gnome.org/GNOME/gtk/issues/new