GNOME Bugzilla – Bug 390055
do not show file size in toolbar for computer:///
Last modified: 2007-07-01 21:24:46 UTC
Browse to computer:///. Select any of the icons (removable drives, Filesystem, Network). Look at the status bar. Marvel at the stupidity of describing e.g. "Network" as 0 bytes. gnome-vfs is not to blame; the dentries don't have GNOME_VFS_FILE_INFO_FIELDS_SIZE set.
void fm_directory_view_display_selection_info (FMDirectoryView *view) { ... for (p = selection; p != NULL; p = p->next) { file = p->data; if (nautilus_file_is_directory (file)) { folder_count++; if (nautilus_file_get_directory_item_count (file, &file_item_count, NULL)) { folder_item_count += file_item_count; } else { folder_item_count_known = FALSE; } } else { non_folder_count++; non_folder_size += nautilus_file_get_size (file); } and GnomeVFSFileSize nautilus_file_get_size (NautilusFile *file) { /* Before we have info on the file, we don't know the size. */ return nautilus_file_info_missing (file, GNOME_VFS_FILE_INFO_FIELDS_SIZE) ? 0 : file->details->info->size; } This is lies.
Created attachment 78952 [details] [review] omit-size-of-special-entries.patch Patch. Logic: show file size info if at least one selected file has GNOME_VFS_FILE_INFO_FIELDS_SIZE set. String changes, unfortunately.
true. we should not display the size at all, that is obsolete.
patch works for me
I've been using this patch for weeks without problems
Can't go in atm due to string freeze, but looks like a good idea.
Here is a bug peek to make remember that the string freeze is finished and this could now be applicable. Just to make you remember before it pass to much time before being applied.
Thanks for the reminder. Commited.