After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 388545 - Clipping regression
Clipping regression
Status: RESOLVED FIXED
Product: librsvg
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: librsvg maintainers
librsvg maintainers
Depends on:
Blocks:
 
 
Reported: 2006-12-22 09:07 UTC by Emmanuel Pacaud
Modified: 2007-01-25 15:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Sample file (70.01 KB, image/svg+xml)
2006-12-22 09:08 UTC, Emmanuel Pacaud
  Details
Wrong rendering (10.21 KB, image/png)
2007-01-12 13:28 UTC, Emmanuel Pacaud
  Details
Correct rendering (18.59 KB, image/png)
2007-01-12 13:31 UTC, Emmanuel Pacaud
  Details
Fix this problem and keep Bug 361923 resolved. (1.19 KB, patch)
2007-01-21 03:21 UTC, Kouhei Sutou
committed Details | Review

Description Emmanuel Pacaud 2006-12-22 09:07:23 UTC
It seems this commit introduce a regression in clipping, perhaps only with svg with ViewBox.

2006-10-13  Kouhei Sutou <kou@cozmixng.org>

	* rsvg-cairo-clip.c: Fix bug with scaling + clipping reported on
	cairo-devel.

I'm attaching a test file that renders correctly without this commit.
Comment 1 Emmanuel Pacaud 2006-12-22 09:08:20 UTC
Created attachment 78779 [details]
Sample file
Comment 2 Emmanuel Pacaud 2007-01-10 12:24:43 UTC
Kouhei, what was the scaling + clipping bug reported on cairo-devel ?

I'm trying to fix this issue, but I don't understand why you removed the matrix transformation...

     Emmanuel.
Comment 3 Kouhei Sutou 2007-01-10 14:14:38 UTC
I reported the problem as Bug #361923.
Comment 4 Kouhei Sutou 2007-01-10 14:45:56 UTC
Could you show me your test program?
Comment 5 Emmanuel Pacaud 2007-01-10 16:54:47 UTC
I don't have a test program. Just use rsvg-view.
Comment 6 Kouhei Sutou 2007-01-12 13:01:31 UTC
I can't find any differences between rendering results of rsvg-view 2.14.4 (Debian package in sid) and rsvg-view 2.16.1 (compiled trunk).

Could you attach expected result and actual result? If this bug can be reproduced with rsvg-convert too, I want you to use that.
Comment 7 Emmanuel Pacaud 2007-01-12 13:28:17 UTC
Created attachment 80108 [details]
Wrong rendering

This is a rendering done using rsvg-convert from librsvg trunk and cairo master.
Comment 8 Emmanuel Pacaud 2007-01-12 13:31:05 UTC
Created attachment 80110 [details]
Correct rendering

Using librsvg 2.16.0 and cairo 1.2.4.
Comment 9 Kouhei Sutou 2007-01-21 03:21:11 UTC
Created attachment 80795 [details] [review]
Fix this problem and keep Bug 361923 resolved.
Comment 10 Emmanuel Pacaud 2007-01-21 15:45:11 UTC
Works for me too...
Comment 11 Kouhei Sutou 2007-01-25 02:36:32 UTC
Is there still any problems?
Comment 12 Dominic Lachowicz 2007-01-25 15:11:03 UTC
Thanks, Kouhei.