After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 388413 - eog crash to eog_image_autorotate
eog crash to eog_image_autorotate
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: image viewer
2.17.x
Other Linux
: Normal critical
: ---
Assigned To: EOG Maintainers
EOG Maintainers
: 392252 393048 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-12-21 21:43 UTC by Sebastien Bacher
Modified: 2007-01-06 11:29 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
change the oritentation only if there is an exif tag for it (580 bytes, patch)
2006-12-21 21:54 UTC, Sebastien Bacher 		none Details | Review

Description Sebastien Bacher 2006-12-21 21:43:47 UTC 
That bug has been described on https://launchpad.net/distros/ubuntu/+source/eog/+bug/76774

"When I double click on a picture taken by my Razr's camera, eog crashes when trying to open it.

http://librarian.launchpad.net/5509568/_usr_bin_eog.1000.crash
Crash log

Attaching crash log.

http://librarian.launchpad.net/5509570/11-03-06_1328.jpg
Picture

Attaching offending picture."

Debug backtrace with eog 2.17.3:

Program received signal SIGSEGV, Segmentation fault.

+ Trace 96073

Thread NaN (LWP 15018)

  • #0 eog_image_autorotate
    at eog-image.c line 1794
  • #1 eog_window_open
    at eog-window.c line 4067
  • #2 job_prepare_model_finished
    at main.c line 195
  • #3 eog_job_call_finished
    at eog-job.c line 440
  • #4 job_finished_cb
    at eog-job-manager.c line 54
  • #5 g_idle_dispatch
    at gmain.c line 3928
  • #6 IA__g_main_context_dispatch
    at gmain.c line 2045
  • #7 g_main_context_iterate
    at gmain.c line 2677
  • #8 IA__g_main_loop_run
    at gmain.c line 2881
  • #9 IA__gtk_main
    at gtkmain.c line 1024
  • #10 main
    at main.c line 623 

(gdb) p e
$1 = (ExifEntry *) 0x0
Comment 1 Sebastien Bacher 2006-12-21 21:54:33 UTC 
Created attachment 78759 [details] [review]
change the oritentation only if there is an exif tag for it
Comment 2 Sebastien Bacher 2006-12-21 21:58:42 UTC 
(should probably use "if (e != NULL)" for source coherence)
Comment 3 Josh Lee 2006-12-21 23:31:51 UTC 
Yay this works. :)
Comment 4 Felix Riemann 2006-12-22 16:29:49 UTC 
Thanks! I just commited your patch in a slightly different form (to get everything into one if-clause):

2006-12-22  Felix Riemann

	* libeog/eog-image.c: (eog_image_get_exif_orientation): Fix NULL
	pointer	dereference when orientation tag is not present in EXIF data.
	Fixes #388413. Patch from Sebastien Bacher <>.
Comment 5 Felix Riemann 2007-01-03 17:52:11 UTC 
*** Bug 392252 has been marked as a duplicate of this bug. ***
Comment 6 Felix Riemann 2007-01-06 11:29:14 UTC 
*** Bug 393048 has been marked as a duplicate of this bug. ***