GNOME Bugzilla – Bug 387897
When in rtl locale, the first workspace should be the right most one in the pager
Last modified: 2007-02-12 21:39:52 UTC
In the current situation, pressing the "move workspace to the right/left" keybindings in metacity resolves in a wierd situation: In the metacity popup, the 1st workspace is the right most one, and in the workspace applet, the first workspace in the left most one. I believe that metacity behavior is correct, and the fix should be in libwnck.
Created attachment 78692 [details] [review] count workspace from right to left in rtl locales
http://bugzilla.gnome.org/show_bug.cgi?id=387893 should be solved together with this bug
Patch looks okay, but I'm surprised that's enough to fix this bug: it looks too easy :-) I'll take a deeper look at pager.c before the next release.
The patch doesn't work when you have more than one row. I'll try to find a quick fix, but since it's late I might go to sleep before finishing... Also, I'd love to know if changing the current workspace with the scrollwheel works in the right way in RTL too (once this bug is fixed). I guess it should be updated for RTL.
Created attachment 81964 [details] [review] patch Could you test this patch and see if it works? Also, you need to verify that it works for an applet on a vertical panel. I believe it's okay.
Btw, Elijah, you'll need to fix this in metacity too :-)
Since the pager is always displayed in a horizontal way, it's ok. But, if the pager would be drawn vertically on a vertical panel (like the menu bar applet is drawn) then the fix will only be wanted for horizontal panels. For now, this patch works just fine.
CCing myself.
Committed.