After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 387421 - Favicon extensions warning
Favicon extensions warning
Status: RESOLVED FIXED
Product: epiphany-extensions
Classification: Deprecated
Component: general
2.17.x
Other All
: Normal trivial
: ---
Assigned To: epiphany-extensions-maint
epiphany-extensions-maint
Depends on:
Blocks:
 
 
Reported: 2006-12-19 05:44 UTC by Priit Laes (IRC: plaes)
Modified: 2006-12-19 16:21 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
favicon-pep-0623.patch (404 bytes, patch)
2006-12-19 05:45 UTC, Priit Laes (IRC: plaes) 		accepted-commit_now Details | Review

Description Priit Laes (IRC: plaes) 2006-12-19 05:44:45 UTC 
Please describe the problem:
Currently favicon extensions displays following warning:
sys:1: DeprecationWarning: Non-ASCII character '\xc2' in file /usr/lib/epiphany/2.17/extensions/favicon.py on line 3, but no encoding declared; see http://www.python.org/peps/pep-0263.html for details

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Patch coming...
Comment 1 Priit Laes (IRC: plaes) 2006-12-19 05:45:24 UTC 
Created attachment 78614 [details] [review]
favicon-pep-0623.patch

Ok to commit?
Comment 2 Christian Persch 2006-12-19 11:36:06 UTC 
Thanks for the patch! Ok to commit to HEAD and gnome-2-16.

Can you check if the other .py files in e-e need the same treatment?
Comment 3 Priit Laes (IRC: plaes) 2006-12-19 16:21:15 UTC 
Other files were fine.

Committed to HEAD and gnome-2-16

2006-12-19  Priit Laes  <plaes@cvs.gnome.org>

        * extensions/favicon/favicon.py:

        Fix DeprecationWarning (Python enchancement proposal 0263). 
        Closes bug #387421.