GNOME Bugzilla – Bug 386767
Sylpheed-Claws renamed Claws Mail
Last modified: 2007-01-03 14:21:06 UTC
Please describe the problem: Hi, Sylpheed-Claws has been renamed Claws Mail. Here's a patch that adds the new binary 'claws-mail' to the searched binaries used to determine if Claws is available, and changes the displayed name to Claws Mail. (People with older Sylpheed-Claws will still see the new name, but I don't think it is problematic). HTH Colin Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Created attachment 78506 [details] [review] Patch (-p0) against CVS Here is the patch.
Comment on attachment 78506 [details] [review] Patch (-p0) against CVS >Index: src/plugins/sylpheed-claws.c >=================================================================== >RCS file: /cvs/gnome/nautilus-sendto/src/plugins/sylpheed-claws.c,v >retrieving revision 1.3 >diff -u -p -u -r1.3 sylpheed-claws.c >--- src/plugins/sylpheed-claws.c 21 Aug 2006 13:37:59 -0000 1.3 >+++ src/plugins/sylpheed-claws.c 17 Dec 2006 12:22:44 -0000 >@@ -27,24 +27,34 @@ > > static GHashTable *hash = NULL; > >+static gchar *get_claws_command(void) >+{ >+ gchar *sc_cmd = NULL; >+ >+ sc_cmd = g_find_program_in_path ("claws-mail"); >+ if (sc_cmd == NULL) >+ sc_cmd = g_find_program_in_path ("sylpheed-claws-gtk2"); >+ if (sc_cmd == NULL) >+ sc_cmd = g_find_program_in_path ("sylpheed-claws"); >+ if (sc_cmd == NULL) >+ sc_cmd = g_find_program_in_path ("sylpheed"); >+ return sc_cmd; >+} Better to use a table and a for loop, easier to extend.
Created attachment 79274 [details] [review] patch (-p0) against SVN Second patch, uses a loop to find command and reduces whitespace changes.
2007-01-03 Bastien Nocera <hadess@hadess.net> * src/plugins/sylpheed-claws.c: (get_claws_command), (init), (send_files): Patch from Colin Leroy <colin@colino.net> to refactor the binary name search for the Sylpheed Claws plugin (Closes: #386767)