After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 386283 - totem-playlist could use icon-name in cell renderer
totem-playlist could use icon-name in cell renderer
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2006-12-15 18:53 UTC by Christian Persch
Modified: 2006-12-15 23:11 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
patch (3.49 KB, patch)
2006-12-15 18:53 UTC, Christian Persch 		accepted-commit_now Details | Review

Description Christian Persch 2006-12-15 18:53:42 UTC 
Instead of loading the icon itself, using icon-name is more convenient and less code.
Comment 1 Christian Persch 2006-12-15 18:53:59 UTC 
Created attachment 78443 [details] [review]
patch
Comment 2 Bastien Nocera 2006-12-15 22:48:56 UTC 
Less code is always nice :)
Comment 3 Christian Persch 2006-12-15 23:11:11 UTC 
        * src/totem-playlist.c: (set_playing_icon), (init_columns),
        (totem_playlist_finalize), (totem_playlist_clear),
        (totem_playlist_class_init): Just use a named icon in the cell
        renderer, and fix a missing return value. Bug #386279 and bug #386283.