GNOME Bugzilla – Bug 385132
solaris gettext support fix
Last modified: 2014-01-20 12:42:55 UTC
Toshi fixes Bug 85217 back in 2003 but his fix had a small bug. We've been carrying around a tiny patch in Sun's builds ever since. I'd like to get it upstream. The bug is that Toshi's fix tests if $host includes "solaris", but $host is only defined if the AC_CANONICAL_HOST macro is used. So this patch makes it a requirement of the GLIB_WITH_NLS macro (which includes the test for solaris in $host)
Created attachment 78218 [details] [review] patch that adds AC_CANONICAL_HOST dep to GLIB_WITH_NLS
Looks fine, please commit to both branches, if you want.
2006-12-13 Matthias Clasen <mclasen@redhat.com> * m4macros/glib-gettext.m4: Require AC_CANONICAL_HOST in GLIB_WITH_NLS. (#385132, Laszlo Peter)
I think this patch is wrong. It forces configure to check for build system type, so building for example gnome-icon-theme as noarch is no longer possible. trying to build gnome-icon-theme-2.19.90: [...] checking build system type... Invalid configuration `noarch-xxx-linux': machine `noarch-xxx' not recognized configure: error: /bin/sh ./config.sub noarch-xxx-linux failed [...] Reverting this patch solves the problem.
Agreed with Fryderyk. I have just run into this same problem trying to build Conduit as noarch. The Alt Linux guys have also run into it: http://lists.altlinux.ru/pipermail/devel/2007-January/040369.html as has PLD Linux: http://lists.pld-linux.org/mailman/pipermail/pld-cvs-commit/Week-of-Mon-20070226/145259.html I am adopting the PLD patch into Mandriva for now. Please revert this change and fix the original problem in a way that causes no regressions. Thanks.
Hmmm... okay. Since the use of AC_CANONICAL_HOST is solely for identifying Solaris, we can replace it with something like checking if `uname -s` matches SunOS.
reopening based on comments
I've removed the AC_CANONICAL_HOST for now. Waiting for a different fix.
different fix never appeared