After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 384160 - doesn't find its icons
doesn't find its icons
Status: RESOLVED FIXED
Product: xchat-gnome
Classification: Other
Component: general
HEAD
Other Linux
: Normal normal
: ---
Assigned To: xchat-gnome maintainers
xchat-gnome maintainers
Depends on:
Blocks:
 
 
Reported: 2006-12-09 20:06 UTC by Christian Persch
Modified: 2007-01-10 23:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (628 bytes, patch)
2006-12-09 20:06 UTC, Christian Persch 		none Details | Review
complete patch (1.24 KB, patch)
2006-12-09 20:07 UTC, Christian Persch 		committed Details | Review
Patch to install application icon into system hicolor theme (1.43 KB, patch)
2007-01-10 20:36 UTC, Brian Pepple 		committed Details | Review

Description Christian Persch 2006-12-09 20:06:18 UTC 
because it doesn't add the theme dir to the search path.
Comment 1 Christian Persch 2006-12-09 20:06:40 UTC 
Created attachment 78049 [details] [review]
patch
Comment 2 Christian Persch 2006-12-09 20:07:19 UTC 
Created attachment 78050 [details] [review]
complete patch
Comment 3 David Trowbridge 2006-12-10 02:42:05 UTC 
Looks fine.  It'd be great if you could move the icons into an app-specific directory at the same time as per dobey's blog entry on the subject along with this :)

See "Themeable app-specific icons" on http://wayofthemonkey.com/ (there doesn't seem to be a way to link to individual entries)
Comment 4 Christian Persch 2006-12-10 18:26:22 UTC 
        * data/icons/hicolor/128x128/apps/Makefile.am:
        * data/icons/hicolor/16x16/apps/Makefile.am:
        * data/icons/hicolor/22x22/apps/Makefile.am:
        * data/icons/hicolor/48x48/apps/Makefile.am:
        * data/icons/hicolor/scalable/apps/Makefile.am:
          - Install the icons in the app sharedir, not the global one.

        * src/fe-gnome/Makefile.am:
        * src/fe-gnome/pixmaps.c: (pixmaps_init):
          - Append the app icon dir to the theme directories, so xchat-gnome
            can find its icons. Bug #384160.
Comment 5 Brian Pepple 2007-01-10 18:38:37 UTC 
The applications logo icon should still be installed into the system hicolor theme.  From dobey's blog:

"While the application's logo icon for use in the system menus, and the app's about box and window titlebars, should still go into the system hicolor theme, following the guidelines in the Icon Theme and Icon Naming specifications, we can't really do this for other icons."

If I get some free time later today, I'll try to work up a patch to correct this.
Comment 6 Brian Pepple 2007-01-10 20:36:55 UTC 
Created attachment 79986 [details] [review]
Patch to install application icon into system hicolor theme

Here's a patch to install the applications icon into the system hicolor theme.  The Makefile.am in the data/ shouldn't need to be modified, since the gtk-update-icon-cache scriptlet wasn't modified with the last patch.
Comment 7 David Trowbridge 2007-01-10 23:06:00 UTC 
Fixed in the development version. The fix will be available in the next major release. Thank you for your bug report.