After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 382652 - Evince should use the "object-select-all" icons
Evince should use the "object-select-all" icons
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-12-05 16:52 UTC by Gabriel Felipe Cornejo
Modified: 2006-12-09 17:23 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
Use "object-select-all" stock icons (829 bytes, patch)
2006-12-05 20:23 UTC, Gabriel Felipe Cornejo 		none Details | Review

Description Gabriel Felipe Cornejo 2006-12-05 16:52:03 UTC 
Please describe the problem:
Current gnome-icon-theme include the "object-select-all" icon, that
were added to the Icon Naming Spec. Evince may use them for the
"Select_All" actions.

A patch for this follows.



Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Gabriel Felipe Cornejo 2006-12-05 17:08:50 UTC 
RCS file: /cvs/gnome/evince/shell/ev-window.c,v
retrieving revision 1.328
diff -u -p -r1.328 ev-window.c
--- shell/ev-window.c   3 Dec 2006 20:54:44 -0000       1.328
+++ shell/ev-window.c   5 Dec 2006 16:56:28 -0000
@@ -3676,7 +3676,7 @@ static const GtkActionEntry entries[] = 
         /* Edit menu */
         { "EditCopy", GTK_STOCK_COPY, NULL, "<control>C", NULL,
           G_CALLBACK (ev_window_cmd_edit_copy) },
-       { "EditSelectAll", NULL, N_("Select _All"), "<control>A", NULL,
+       { "EditSelectAll", GTK_STOCK_SELECT_ALL, N_("Select _All"), "<control>A", NULL,
          G_CALLBACK (ev_window_cmd_edit_select_all) },
         { "EditFind", GTK_STOCK_FIND, N_("_Find..."), "<control>F",
           N_("Find a word or phrase in the document"),
cvs server: Diffing test
cvs server: Diffing thumbnailer
cvs server: Diffing tiff
cvs server: Diffing viewer
Comment 2 Gabriel Felipe Cornejo 2006-12-05 20:23:09 UTC 
Created attachment 77754 [details] [review]
Use "object-select-all" stock icons
Comment 3 Nickolay V. Shmyrev 2006-12-09 17:23:03 UTC 
Applied, thanks a lot.