After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 380966 - Discoverer doesn't cope well with demuxers that don't create all pads at start
Discoverer doesn't cope well with demuxers that don't create all pads at start
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-python
git master
Other Linux
: Normal normal
: 0.10.8
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-11-30 17:19 UTC by Michael Smith
Modified: 2007-06-08 16:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch as described (4.80 KB, patch)
2006-11-30 17:20 UTC, Michael Smith 		none Details | Review
Better patch! (4.89 KB, patch)
2006-11-30 20:00 UTC, Michael Smith 		committed Details | Review

Description Michael Smith 2006-11-30 17:19:55 UTC 
This patch changes it to:
 1) If we've received no-more-pads, getting caps on our sinks makes us finish
 2) otherwise, add success cases to the timeout (for formats like mpeg that can't send no-more-pads)

This makes it work for more cases.

(not proposing to break the freeze for this)
Comment 1 Michael Smith 2006-11-30 17:20:25 UTC 
Created attachment 77431 [details] [review]
Patch as described
Comment 2 Michael Smith 2006-11-30 20:00:39 UTC 
Created attachment 77443 [details] [review]
Better patch!

This patch doesn't race, unlike the previous one.
Comment 3 Wim Taymans 2007-03-06 09:03:28 UTC 
what's up with this?
Comment 4 Michael Smith 2007-03-06 09:58:14 UTC 
I dunno, I guess a gst-python hacker should review it. Mr Hervey?

I still have it in my gst-cvs tree, and have been using it since I wrote it.
Comment 5 Edward Hervey 2007-05-02 16:52:55 UTC 
looks fine to me. Might want to talk to sebastien for race-related issues in discoverer, I think he has some patches too.
Comment 6 Edward Hervey 2007-06-08 16:16:59 UTC 
2007-06-08  Edward Hervey  <edward@fluendo.com>

	Patch by : Michael Smith  <msmith@fluendo.com>
	* gst/extend/discoverer.py:
	Better support for demuxers that don't create all pads at startup.
	Fixes #380966