After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 380746 - Podcasts should display album art
Podcasts should display album art
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Podcast
0.9.6
Other All
: Normal enhancement
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-11-30 03:26 UTC by Scott Harmon
Modified: 2007-01-23 08:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add Podcast Cover Image support (4.02 KB, patch)
2007-01-08 12:14 UTC, Martin Szulecki
none Details | Review
Add Podcast Cover Image support (4.17 KB, patch)
2007-01-08 12:39 UTC, Martin Szulecki
committed Details | Review

Description Scott Harmon 2006-11-30 03:26:54 UTC
Some podcasts have embedded album art.  Rhythmbox should display this in the usual album art place.
Comment 1 Martin Szulecki 2007-01-08 12:14:09 UTC
Created attachment 79738 [details] [review]
Add Podcast Cover Image support

- Add cover art support for podcasts
- Fix parsing "itunes:image" tags in feeds
Comment 2 Martin Szulecki 2007-01-08 12:39:54 UTC
Created attachment 79742 [details] [review]
Add Podcast Cover Image support

- Add cover art support for podcasts
- Fix parsing "itunes:image" tags in feeds

* Added a check to properly work only on podcast rhythmdb entries
Comment 3 Alex Lancaster 2007-01-09 00:54:15 UTC
Works for me on most of the Podcasts that have images.
Comment 4 Martin Szulecki 2007-01-12 12:19:16 UTC
If I under(In reply to comment #3)
> Works for me on most of the Podcasts that have images.
> 

I pick that from writing "most", some of those Podcasts you expect from having images don't show them with this patch.

The podcast xml parser had sometimes skipped adding <image> entries to the rhythmdb podcast-feed prior to the patch.

Thus you will most likely have to to re-subscribe to any of your current Podcasts in order for the rhythmdb entry to properly re-parse and add an <image> property.

This could be fixed by altering "rb_podcast_manager_insert_feed()" to also set the data->* when updating the feed and not just when creating a new one.

I can do the required change if that would be desired.
Comment 5 Alex Lancaster 2007-01-15 05:56:16 UTC
(In reply to comment #4)
> > Works for me on most of the Podcasts that have images.

> I pick that from writing "most", some of those Podcasts you expect from having
> images don't show them with this patch.

Sorry, badly worded on my part, I really mean that it works on all the podcasts that have images, which is "most" of my feeds.  It always finds images for podcasts for which I know do (or should) have associated images.  (I haven't checked all my podcasts exhaustively, however.)
Comment 6 James "Doc" Livingston 2007-01-23 08:08:11 UTC
Committed to svn with the small change required to update feed info. Thanks.