GNOME Bugzilla – Bug 380156
History does not show date and time of URL access
Last modified: 2007-11-07 15:20:24 UTC
In the history window, the date and time of the last access to URLS should also be shown as a column. Two reasons: 1) The last access date is certainly an integral datum for any kind of document history. 2) As it is now, if you change the ordering by clicking on the "Titel" or "Address" column, you cannot sort it by date again. Other information:
Agree. I'll try a patch.
Question/Comment: Why the View menu is made of radio buttons and not checkbuttons?. I would find easier for this bug and well for that menu in general to have checkbuttons so users check what they want to see and not select a combination. I mean, they do their own combination. It wouldn't take extra space nor extra reasoning. What do you think?
(In reply to comment #2) > Question/Comment: > > Why the View menu is made of radio buttons and not checkbuttons?. > > I would find easier for this bug and well for that menu in general to have > checkbuttons so users check what they want to see and not select a combination. > I mean, they do their own combination. > It wouldn't take extra space nor extra reasoning. > > What do you think? I second this. For three possible columns, there would already be 6 combinations to choose from. If there ever are more columns added to choose from, maybe the way it is done in Evolution for choosing which Headers to show should be adopted?
Any news on this?
Created attachment 98582 [details] [review] proposed implementation Attached patch implements this request. About the patch: - it substitutes radiobuttons in View menu with checkbuttons. - adds two file (lib/ephy-time-helpers.[ch]) that contains code stolen from Rhythmbox (which in turn stole it from eel and evolution I think) to handle strftime in a pretty way. - modifies the way displayed columns names are stored in the gconf entry to be remembered: instead of "title" and "address" we have "ViewTitle", "ViewAddress" and "ViewDateTime" (same naes as GtkActions), this way I can use them directly to call relevant GtkActions when needed. Don't know if this is a problem for an upgrade from a previous version (it just leaves unused text in the gconf entry).
Created attachment 98583 [details] [review] forgot a g_list_free Forgot a call to g_list_free.
+ * Copyright (C) 2000 Eazel, Inc. Use © instead. + if (!strcmp (action_name, "ViewTitle")) Test == 0. + set_column_visibility (view, "ViewTitle", (details_value & VIEW_TITLE)); + set_column_visibility (view, "ViewAddress", (details_value & VIEW_ADDRESS)); + set_column_visibility (view, "ViewDateTime", (details_value & VIEW_DATETIME)); [...] + gtk_toggle_action_set_active (GTK_TOGGLE_ACTION (action_title), (details_value & VIEW_TITLE)); + gtk_toggle_action_set_active (GTK_TOGGLE_ACTION (action_address), (details_value & VIEW_ADDRESS)); + gtk_toggle_action_set_active (GTK_TOGGLE_ACTION (action_datetime), (details_value & VIEW_DATETIME)); Can't the signal handlers of the toggled signal take care of updating the visibility, without setting it explicitly the first time? BTW, there's one strftime use in src/pdm-dialog.c that could possibly be replaced by one of the time helpers too.
Created attachment 98657 [details] [review] proposed implementation v2 - fixed style issues for ephy-time-helpers.* and for !strcmp (). - fixed handling of the case when user starts Ephy for the first time and the string is NULL (i was wrongly using || instead of | to set flags). - removed the explicit set of column visibility. To make things work properly, I had to modify get_details_value to add relevant values to the gconf string list in the case it is NULL.
Committed to trunk. ------------------------------------------------------------------------ r7641 | cosimoc | 2007-11-06 20:56:42 +0100 (mar, 06 nov 2007) | 5 lines Adds a column in the history window showing the date and the time of the visit, substitutes radiobuttons with checkboxes in the View menu of the window. Also, adds lib/ephy-time-helpers that contains a strftime() implementation. Fix bug #380156.
*** Bug 138851 has been marked as a duplicate of this bug. ***