After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 376848 - [PATCH] ISO extraction does not work
[PATCH] ISO extraction does not work
Status: RESOLVED FIXED
Product: file-roller
Classification: Applications
Component: general
2.17.x
Other FreeBSD
: Normal normal
: ---
Assigned To: Paolo Bacchilega
file-roller-maint
: 363459 374675 377595 380912 382229 384944 394369 416404 425137 426156 432855 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-11-19 01:13 UTC by Joe Marcus Clarke
Modified: 2007-07-15 15:45 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
Fix ISO file extraction (1.44 KB, patch)
2006-11-19 01:18 UTC, Joe Marcus Clarke 		none Details | Review
Fix ISO file extraction (corrected patch) (1.73 KB, patch)
2006-11-19 01:24 UTC, Joe Marcus Clarke 		none Details | Review

Description Joe Marcus Clarke 2006-11-19 01:13:51 UTC 
In file-roller 2.17.x with the addition of the new isoinfo.sh script, there are two problems which prevent a file from being extracted from an ISO image file.  The first is a trivial problem in that the isoinfo.sh script contains:

echo "isoinfo -d -i $filename"

Which corrupts the stdout data stream.  The second problem is that the fully-qualified path to the file within the ISO image is no longer being passed to isoinfo.  Instead only the original_path is passed which lacks a leading '/'.  This will result in a zero-length file being extracted.

Attached is a patch that corrects both problems.
Comment 1 Joe Marcus Clarke 2006-11-19 01:18:27 UTC 
Created attachment 76819 [details] [review]
Fix ISO file extraction
Comment 2 Joe Marcus Clarke 2006-11-19 01:24:59 UTC 
Created attachment 76820 [details] [review]
Fix ISO file extraction (corrected patch)
Comment 3 Paolo Bacchilega 2006-11-19 10:37:53 UTC 
fixed in current CVS, thanks.
Comment 4 Paolo Bacchilega 2006-12-19 20:39:02 UTC 
*** Bug 363459 has been marked as a duplicate of this bug. ***
Comment 5 Paolo Bacchilega 2006-12-19 23:02:18 UTC 
*** Bug 374675 has been marked as a duplicate of this bug. ***
Comment 6 Paolo Bacchilega 2006-12-19 23:04:49 UTC 
*** Bug 377595 has been marked as a duplicate of this bug. ***
Comment 7 Paolo Bacchilega 2006-12-19 23:07:00 UTC 
*** Bug 382229 has been marked as a duplicate of this bug. ***
Comment 8 Paolo Bacchilega 2006-12-19 23:07:12 UTC 
*** Bug 384944 has been marked as a duplicate of this bug. ***
Comment 9 Paolo Bacchilega 2006-12-19 23:07:23 UTC 
*** Bug 380912 has been marked as a duplicate of this bug. ***
Comment 10 Joe Marcus Clarke 2007-01-10 19:49:32 UTC 
Only the first patch was committed to CVS.  The patch for fr-command-iso.c was not, and this is needed for ISO extraction to work properly.
Comment 11 Paolo Bacchilega 2007-01-11 09:38:54 UTC 
I don't understand how that patch can work, cur_path is never updated when extracting files, cur_path is only used when listing the content of a iso image.
Comment 12 Joe Marcus Clarke 2007-01-12 20:50:54 UTC 
I stand corrected.  As of 2.17.5, this patch is no longer required.  Sorry for the noise.
Comment 13 Susana 2007-03-09 12:10:44 UTC 
*** Bug 416404 has been marked as a duplicate of this bug. ***
Comment 14 Pedro Villavicencio 2007-04-02 02:00:04 UTC 
*** Bug 425137 has been marked as a duplicate of this bug. ***
Comment 15 Paolo Bacchilega 2007-07-15 15:43:08 UTC 
*** Bug 432855 has been marked as a duplicate of this bug. ***
Comment 16 Paolo Bacchilega 2007-07-15 15:44:40 UTC 
*** Bug 394369 has been marked as a duplicate of this bug. ***
Comment 17 Paolo Bacchilega 2007-07-15 15:45:37 UTC 
*** Bug 426156 has been marked as a duplicate of this bug. ***