After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 375952 - Custom shortcut for GIMP help
Custom shortcut for GIMP help
Status: RESOLVED WONTFIX
Product: GIMP
Classification: Other
Component: User Interface
git master
Other All
: Normal enhancement
: ---
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2006-11-16 15:32 UTC by Mikko Vatanen
Modified: 2006-11-18 20:02 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Mikko Vatanen 2006-11-16 15:32:30 UTC
Hard coded shortcuts restrict customization of GIMP interface. Experienced user doesn't need help that often and for example it would be in better use when remapped to show dialogs.
Comment 1 Michael Natterer 2006-11-16 15:40:27 UTC
What exactly do you mean? Please be more specific, and perhaps
look at ~/.gimp-2.3/gtkrc
Comment 2 Mikko Vatanen 2006-11-16 16:54:47 UTC
Yes, I'll try to be more specific. I changed ~/.gimp-2.3/gtkrc to show help with F2, but when Gimp toolbox or dialogs are focused I still get help from both F1 and F2.

I'm not familiar enough with Gimp's code yet, but there seems to be some hard coded GDK_F1 keys hanging. If F1-kay is already user remappable, then using hard coded keys cause problems. I hope this is some help.


app/widgets/gimpuimanager:955

  /*  For any valid accelerator key except F1, continue with the
   *  standard GtkMenuShell callback and assign a new shortcut, but
   *  don't assign a shortcut to the help menu entries ...
   */
  if (kevent->keyval != GDK_F1)


libgimpwidgets/gimphelpui.c:168

      gtk_binding_entry_add_signal (binding_set, GDK_F1, 0,
                                    "show_help", 1,        
                                    GTK_TYPE_WIDGET_HELP_TYPE,
                                    GIMP_WIDGET_HELP_TYPE_HELP);
      gtk_binding_entry_add_signal (binding_set, GDK_KP_F1, 0,  
                                    "show_help", 1,           
                                    GTK_TYPE_WIDGET_HELP_TYPE,
                                    GIMP_WIDGET_HELP_TYPE_HELP);
Comment 3 Michael Natterer 2006-11-16 17:20:21 UTC
The stuff from gimphelpui.c is not hardcoded and is exactly what
you can change by editing gtkrc. However at some point we decided
that F1 should be the only key where reconfiguring should be
impossible, because it's the help key, and not some random other
shortcut. Perhaps we should remove that example from the gtkrc.

Closing as WONTFIX since this is a usability decision, not a bug.
Comment 4 Sven Neumann 2006-11-17 07:42:50 UTC
Yes, let's better remove that example from gtkrc then.
Comment 5 Michael Natterer 2006-11-18 20:02:13 UTC
Done:

2006-11-18  Michael Natterer  <mitch@gimp.org>

	* etc/gtkrc: remove example about adding a help keybinding
	(bug #375952).