After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 373895 - nautilus 2.16.2 desktop icons's position bug
nautilus 2.16.2 desktop icons's position bug
Status: RESOLVED DUPLICATE of bug 330298
Product: nautilus
Classification: Core
Component: Desktop
2.16.x
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 374283 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-11-11 15:45 UTC by wall_john
Modified: 2006-11-20 09:02 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
nautilus-2.16.2-desktop-icon-position.patch (420 bytes, patch)
2006-11-11 15:50 UTC, wall_john
none Details | Review
proposal patch to fix (902 bytes, patch)
2006-11-14 19:36 UTC, Luis Medinas
none Details | Review

Description wall_john 2006-11-11 15:45:27 UTC
Please describe the problem:
In the recently released nautilus 2.16.2, the desktop icons(
computer,home,trash)'s position is not be loaded from saved 
nautilus icons position info (~/.nautilus/metafiles/) and 
show in a error position.

Steps to reproduce:
1. every time when i enter gnome
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Because desktop icon file always return has_lazy_position is true(see below),
function finish_adding_new_icons in nautilus-icon-container.c will allocate
a new position to it. 

There is a patch to resolve the problem(maybe).

--- nautilus-2.16.2/src/file-manager/fm-icon-view.c.orig        2006-11-11 22:55:32.000000000 +0800
+++ nautilus-2.16.2/src/file-manager/fm-icon-view.c     2006-11-11 22:55:52.000000000 +0800
@@ -536,7 +536,8 @@ file_has_lazy_position (FMDirectoryView 
         * icon we don't overlap that one.
         */
 
-       return NAUTILUS_IS_DESKTOP_ICON_FILE (file);
+       //return NAUTILUS_IS_DESKTOP_ICON_FILE (file);
+    return FALSE;
 }
 
 static void
Comment 1 wall_john 2006-11-11 15:50:56 UTC
Created attachment 76394 [details] [review]
nautilus-2.16.2-desktop-icon-position.patch
Comment 2 Christian Kirbach 2006-11-12 11:12:34 UTC
isn't this basically what Bug 330298 is?
Comment 3 onip 2006-11-12 12:21:42 UTC
Tried tha patch here on gentoo (x86) and it seems to work correctly, thanks
Comment 4 Andrea Antolini 2006-11-13 11:53:13 UTC
*** Bug 374283 has been marked as a duplicate of this bug. ***
Comment 5 Andrea Antolini 2006-11-14 07:12:18 UTC
The proposed patch works fine also on slack11 (x86), gnome 2.16.2 compiled  from scratch... 
Comment 6 Luis Medinas 2006-11-14 19:35:26 UTC
I did this patch that was reverting Federico changes on file_has_lazy_position function. This fixes the problem. If you don't like the current solution (drop half patch of Federico) please give a good one.

Here is the patch we are using on Gentoo Linux.

Thanks for understanding
Comment 7 Luis Medinas 2006-11-14 19:36:44 UTC
Created attachment 76588 [details] [review]
proposal patch to fix
Comment 8 wall_john 2006-11-15 04:07:41 UTC
Luis Medinas's reverting patch is correct better!
Comment 9 Kjel Oslund 2006-11-19 19:10:41 UTC
Confirming this problem exists in Mandriva Cooker nautilus-2.16.2-2md2007.1
Comment 10 Alexander Larsson 2006-11-20 09:02:25 UTC
I reverted all of federicos patch. We have to look into it more to know why it was causing problems (but not for federico).


*** This bug has been marked as a duplicate of 330298 ***