After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 373837 - Migrate from GnomeFontPicker to GtkFontButton
Migrate from GnomeFontPicker to GtkFontButton
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.10.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on: 380534
Blocks:
 
 
Reported: 2006-11-11 13:18 UTC by Matthew Barnes
Modified: 2013-09-13 00:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (9.78 KB, patch)
2006-11-11 14:33 UTC, Matthew Barnes
none Details | Review
Revised patch (7.43 KB, patch)
2006-11-11 14:37 UTC, Matthew Barnes
committed Details | Review

Description Matthew Barnes 2006-11-11 13:18:16 UTC
Evolution is still using the deprecated GnomeFontPicker widget from libgnomeui
[1].  GTK+ 2.4 introduced GtkFontButton [2] as a replacement.

The migration is pretty trivial.


[1] http://developer.gnome.org/doc/API/2.0/libgnomeui/GnomeFontPicker.html
[2] http://developer.gnome.org/doc/API/2.0/gtk/GtkFontButton.html
Comment 1 Matthew Barnes 2006-11-11 14:33:54 UTC
Created attachment 76388 [details] [review]
Proposed patch
Comment 2 Matthew Barnes 2006-11-11 14:37:34 UTC
Created attachment 76389 [details] [review]
Revised patch

Previous patch had some glade-generated noise.
Comment 3 Matthew Barnes 2006-12-04 12:52:00 UTC
This bug requires clarification of Evolution's library requirements.
Please see bug #380354.
Comment 4 Matthew Barnes 2006-12-04 12:53:17 UTC
Sorry, that was supposed to be bug #380534.
Comment 5 Matthew Barnes 2007-02-20 13:45:10 UTC
Ping - Can someone review this?  It's an easy one.
Comment 6 Matthew Barnes 2007-03-29 14:17:31 UTC
This patch has been in Fedora for four months now with no reported problems.

Committed to Subversion trunk, revision 33337.