GNOME Bugzilla – Bug 371156
Shift+click should open place item in a new window
Last modified: 2021-06-18 15:18:04 UTC
As summary says, Shift+click should open place item in a new window. Other information:
Created attachment 138271 [details] [review] Tentative patch
Mmm, just noted that the second button can be used for this purpose... Ignore the patch please.
We already have middle click doing this, would that be enough?
Middle click opens in a new tab, and we use Shift+Click elsewhere, so this could make sense. Stefano: any chance you could update your patch?
Cosimo: I don't have access to git from here (the uni uses a very restrictive proxy == already tried, didn't work.) Will try to get it done during the weekend.
Created attachment 202710 [details] [review] Updated patch.
Review of attachment 202710 [details] [review]: Usually the events from the first mouse button are handled on button release, not press; actually, the code already has a button-release handler some lines before this. I think it'd be better to add the window/tab logic there instead of in button-press here. ::: src/nautilus-places-sidebar.c @@ +2970,3 @@ } + has_mod = ((event->state & gtk_accelerator_get_default_mod_mask ()) & Why are you and-ing this with gtk_accelerator_get_default_mod_mask()? That shouldn't be required.
As for why I have not updated the patch, see: http://mail.gnome.org/archives/nautilus-list/2011-December/msg00005.html
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version of Files (nautilus), then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new ticket at https://gitlab.gnome.org/GNOME/nautilus/-/issues/ Thank you for your understanding and your help.