After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 370195 - uulib/fptools.c assert issue - crash
uulib/fptools.c assert issue - crash
Status: RESOLVED FIXED
Product: Pan
Classification: Other
Component: general
pre-1.0 betas
Other Linux
: Normal major
: 1.0
Assigned To: Charles Kerr
Pan QA Team
: 372786 378635 406848 433492 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-11-03 20:31 UTC by John N. Laliberte
Modified: 2007-04-27 04:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
pan_crash_poc.c (1.31 KB, text/plain)
2006-11-03 20:32 UTC, John N. Laliberte 		  Details
0.118 patch (2.29 KB, patch)
2006-11-06 22:37 UTC, Charles Kerr 		none Details | Review
fptools.c:455: _FP_fgets: Assertion `*buf' failed; pan 0.122 (1.03 KB, text/plain)
2007-02-04 19:56 UTC, Samuli Kärkkäinen 		  Details
A different fptools crash, now for real in Pan 0.122 (2.32 KB, text/plain)
2007-02-05 06:47 UTC, Samuli Kärkkäinen 		  Details
patch to fix. (2.51 KB, patch)
2007-02-05 21:43 UTC, Charles Kerr 		committed Details | Review
0.123 patch (633 bytes, patch)
2007-02-10 06:20 UTC, Charles Kerr 		committed Details | Review

Description John N. Laliberte 2006-11-03 20:31:41 UTC 
Hello,

Here is a link to the original bug report with backtrace:
https://bugs.gentoo.org/151476


Attached is a small program designed to replicate the problem in uulib.  It is commented and should be easy to understand, but do not hesitate to contact me.

Basically, the assert fails due to ascii nulls.

Thanks,
John
Comment 1 John N. Laliberte 2006-11-03 20:32:22 UTC 
Created attachment 75961 [details]
pan_crash_poc.c
Comment 2 Charles Kerr 2006-11-06 22:37:27 UTC 
Created attachment 76121 [details] [review]
0.118 patch

This should fix it.
Comment 3 Charles Kerr 2006-11-09 03:17:46 UTC 
*** Bug 372786 has been marked as a duplicate of this bug. ***
Comment 4 Christophe Lambin 2006-11-24 06:36:23 UTC 
*** Bug 378635 has been marked as a duplicate of this bug. ***
Comment 5 Samuli Kärkkäinen 2007-02-04 19:56:43 UTC 
Created attachment 81889 [details]
fptools.c:455: _FP_fgets: Assertion `*buf' failed; pan 0.122

Happens repeatably every time as pan starts processing task queue upon startup.
Comment 6 Charles Kerr 2007-02-05 04:41:35 UTC 
But that assertion is on line 458 in 0.122... 
The last release that had that assertion on line 455 was 0.119.
I think you must be using the wrong version by accident.
Comment 7 Samuli Kärkkäinen 2007-02-05 06:38:42 UTC 
You're right. Sorry. The bug isn't occurring anymore in 0.122.
Comment 8 Samuli Kärkkäinen 2007-02-05 06:47:19 UTC 
Created attachment 81916 [details]
A different fptools crash, now for real in Pan 0.122

However in 0.122 I'm getting this different bug in fptools.
Comment 9 Charles Kerr 2007-02-05 21:43:39 UTC 
Created attachment 81957 [details] [review]
patch to fix.
Comment 10 Charles Kerr 2007-02-10 06:20:14 UTC 
Created attachment 82264 [details] [review]
0.123 patch

The previous attachment introduced a bug into 0.123 that could
skip some lines, breaking decoding.  This was reported by walt
in the pan-users mailing list.  Attached is a patch to 0.123
that fixes this problem.
Comment 11 Charles Kerr 2007-02-12 00:16:58 UTC 
*** Bug 406848 has been marked as a duplicate of this bug. ***
Comment 12 Charles Kerr 2007-04-27 04:15:40 UTC 
*** Bug 433492 has been marked as a duplicate of this bug. ***