After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 369302 - The relation of Label_For/Labeled_By is missing in sound preferences.
The relation of Label_For/Labeled_By is missing in sound preferences.
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Sound
git master
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-11-02 08:46 UTC by Tim Miao
Modified: 2007-02-15 09:48 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
Add a11y label relations in the Devices tab (3.91 KB, patch)
2007-01-29 08:32 UTC, Patrick Wade
committed Details | Review

Description Tim Miao 2006-11-02 08:46:16 UTC
Please describe the problem:
This is an a11y bug.

Steps to reproduce:
1. Invoke sound preferences in Launch->Preferences->Sound.
2. Select the Devices tab.
3. Invoke the at-poke, track the structure in this tab.


Actual results:
The relation of Label_For/Labeled_By is missing in Devices tab.

Expected results:
The relation should be there so that orca could report each combobox with its label.

Does this happen every time?
Yes.

Other information:
No.
Comment 1 Patrick Wade 2007-01-29 08:32:58 UTC
Created attachment 81412 [details] [review]
Add a11y label relations in the Devices tab
Comment 2 Kjartan Maraas 2007-01-29 11:53:33 UTC
Moving this to control-center.
Comment 3 Patrick Wade 2007-02-02 11:05:23 UTC
Any maintainer input on this, please? Thanks in advance.
Comment 4 Jens Granseuer 2007-02-05 17:03:14 UTC
Looks good to me, but since I don't have a lot of insight into a11y matters, let me ask a stupid question: Why is this only needed on the devices tab?
Comment 5 Patrick Wade 2007-02-05 17:38:06 UTC
Because running the "at-poke" a11y test tool shows that the appropriate ATK
relations are already in place for the 'Sounds' tab, unlike the 'Devices' one.
Comment 6 Jens Granseuer 2007-02-05 17:51:13 UTC
Hrm, let me rephrase my question: The glade file does not contain any other <atkrelation> tags. Why are the relations in place for the other tabs, but not for devices?
Comment 7 Patrick Wade 2007-02-06 12:24:44 UTC
The labels (on the Sounds tab) most probably come from the elements being explicitly created with gtk_label_new_with_mnemonic (in one of the libsounds library calls), which gives the atk relations 'for free' when created that way, as opposed to when parsing a glade file (i.e. the labels on the Devices tab) - in which case the atk relations have to be manually specified (as per the patch).
Comment 8 Jens Granseuer 2007-02-06 22:13:54 UTC
Ok, that sounds plausible. Thanks for the explanation.
Comment 9 Jens Granseuer 2007-02-10 13:10:38 UTC
2007-02-10  Jens Granseuer  <jensgr@gmx.net>
                              
        Patch by: Patrick Wade <patrick.wade@sun.com>
                              
        * sound-properties.glade: add a11y label relations for the devices
        tab (fixes bug #369302)
Comment 10 Patrick Wade 2007-02-15 09:48:28 UTC
Thanks for the commit Jens.