After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 364709 - glib-mkenums: parse_trigraph() chokes on quoted commas
glib-mkenums: parse_trigraph() chokes on quoted commas
Status: RESOLVED OBSOLETE
Product: glib
Classification: Platform
Component: gobject
unspecified
Other All
: Normal normal
: ---
Assigned To: Tim Janik
gtkdev
: 506986 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-10-24 13:52 UTC by Michael Natterer
Modified: 2018-05-24 10:53 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Michael Natterer 2006-10-24 13:52:01 UTC
In the constructed case:

typedef enum {
  FOO_VALUE /*< name="eek, a comma" >*/
} Foo;

The quoted comma breaks parsing in glib-mkenums, line 26 where is
does:

    for $opt (split /\s*,\s*/, $opts) {

Replacing this by:

    for $opt (quotewords(",", "true", $opts)) {

Works fine in gimp-mkenums, which supports quoted commas.
Comment 1 Tim Janik 2007-03-12 11:40:57 UTC
is tehre a better use case than "ee, a comma"? i.e. why would you put a comma there if you don't eek?
Comment 2 Michael Natterer 2008-02-27 11:00:47 UTC
Yes there is or was in gimp, but I don't find it right now.

Regardless, a comma within quotes should not be interpreted as
a field separator, right?
Comment 3 Matthias Clasen 2013-02-05 04:21:09 UTC
*** Bug 506986 has been marked as a duplicate of this bug. ***
Comment 4 GNOME Infrastructure Team 2018-05-24 10:53:08 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glib/issues/65.