After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 363164 - Become a nice tickless person
Become a nice tickless person
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Movie player
2.16.x
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks: 356586
 
 
Reported: 2006-10-18 15:27 UTC by Bastien Nocera
Modified: 2007-03-30 02:37 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Bastien Nocera 2006-10-18 15:27:33 UTC
Obviously, that's not very useful when playing a film, as the machine will be busy anyway, but we should be tickless when not playing anything (or when paused).
Comment 2 Bastien Nocera 2006-11-27 14:04:10 UTC
Culprit 1:
gui_update_cb() in totem.c
Only updates the volume to match what's in the backend. We should use property notifies and clean it up a bit

Culprit 2:
bacon_video_widget_tick_send() in bacon-video-widget-xine.c
We should disable it when we close the files, and restart when we open a new one.
Comment 3 Bastien Nocera 2006-11-27 14:13:13 UTC
Probably need to figure out how to avoid wake ups when paused as well, in both the GStreamer and the xine-lib backends.
Comment 4 Bastien Nocera 2006-11-27 16:56:08 UTC
Culprit 1 is dead.

2006-11-27  Bastien Nocera  <hadess@hadess.net>

        * src/backend/bacon-video-widget-gst-0.10.c:
        (bacon_video_widget_class_init), (bacon_video_widget_get_property),
        (bacon_video_widget_set_tv_out),
        (bacon_video_widget_can_set_volume),
        (bacon_video_widget_set_volume),
        (bacon_video_widget_set_show_visuals):
        * src/backend/bacon-video-widget-xine.c:
        (bacon_video_widget_class_init), (bacon_video_widget_init),
        (bacon_video_widget_get_property), (bacon_video_widget_set_volume),
        (bacon_video_widget_set_tv_out):
        * src/backend/bacon-video-widget.h:
        * src/totem-preferences.c: (on_tvout_toggled):
        * src/totem.c: (volume_notify_cb), (totem_callback_connect),
        (video_widget_create): Remove the TV-Out restart dialogue bits, both
        GStreamer and xine-lib can do without (Helps: 322226),
        Remove the need for update_gui_cb polling so that we don't wake Totem
        up when not playing anything (Helps: #363164)
Comment 5 Bastien Nocera 2007-03-30 02:37:41 UTC
2007-03-30  Bastien Nocera  <hadess@hadess.net>

        * src/backend/bacon-video-widget-gst-0.10.c: (bvw_bus_message_cb),
        (got_time_tick), (bacon_video_widget_close),
        (bacon_video_widget_is_seekable):
        * src/backend/bacon-video-widget-xine.c: (bacon_video_widget_init),
        (setup_config), (bacon_video_widget_idle_signal),
        (bacon_video_widget_unrealize), (bacon_video_widget_new),
        (bacon_video_widget_reconfigure_tick),
        (bacon_video_widget_tick_send),
        (bacon_video_widget_open_with_subtitle), (bacon_video_widget_play),
        (bacon_video_widget_stop), (bacon_video_widget_close),
        (bacon_video_widget_pause):
        * src/totem-private.h:
        * src/totem.c: (update_skip_to),
        (totem_action_set_mrl_with_warning), (update_seekable),
        (update_current_time), (property_notify_cb),
        (totem_action_skip_to):

        Don't run the ticks when paused or stopped,
        Update seekable only when the value has changed in the backend, not
        for every tick (Closes: #363164)