After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 363066 - Keep smart playlists from slamming the CPU/freezing banshee
Keep smart playlists from slamming the CPU/freezing banshee
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Smart Playlists
git master
Other Linux
: Normal major
: 2.x
Assigned To: Gabriel Burt
Gabriel Burt
Depends on:
Blocks:
 
 
Reported: 2006-10-18 05:53 UTC by Scott Peterson
Modified: 2006-11-04 17:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Implements a LiveUpdating bool to control live updating (3.50 KB, patch)
2006-10-18 05:56 UTC, Scott Peterson 		none Details | Review
Tabs -> Spaces (3.69 KB, patch)
2006-10-21 18:23 UTC, Scott Peterson 		none Details | Review

Description Scott Peterson 2006-10-18 05:53:22 UTC 
With 0.11.1, every track's Changed event will trigger a complete recheck of every smart playlist. I'm writing an import pluggin that modifies many tracks in a row. The performance hit of re-evaluating all smart playlists after each change makes the plugin virtually unusable. I think there should be a way to disable "live updating" of smart playlists. I've written a patch, but I'm not confident of its robustness - I'm something of a newbie. Pointers?
Comment 1 Scott Peterson 2006-10-18 05:56:21 UTC 
Created attachment 74920 [details] [review]
Implements a LiveUpdating bool to control live updating
Comment 2 Scott Peterson 2006-10-21 18:23:58 UTC 
Created attachment 75147 [details] [review]
Tabs -> Spaces

Changed tabs to 4 spaces.
Comment 3 Gabriel Burt 2006-11-04 07:59:21 UTC 
Instead of having a property in the Smart Playlists to turn off automatic updating, I've committed a patch that adds in rate limiting, based on the number of events coming in and how much time the updates they are causing take.  Please let me know if this fixes your problem - it should.  Thanks for the patch, the effort is appreciated.  This was actually a lot more serious problem - it actually made importing very very slow depending on certain circumstances.
Comment 4 Scott Peterson 2006-11-04 17:27:25 UTC 
Works like a charm. Thanks!