After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 360458 - Avoid markup in translatable messages
Avoid markup in translatable messages
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: User Interface
git master
Other Linux
: Normal trivial
: 2.4
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2006-10-07 18:46 UTC by Elijah Newren
Modified: 2006-10-09 13:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove markup (1.47 KB, patch)
2006-10-07 18:47 UTC, Elijah Newren 		rejected Details | Review

Description Elijah Newren 2006-10-07 18:46:46 UTC 
As translators often say, please don't include markup in translateable
messages. Move the markup outside of the gettext call.  See
http://developer.gnome.org/doc/tutorials/gnome-i18n/developer.html#avoid-markup

Affected messages (other than those from glade, since bug 97061 has to be fixed
first to handle those):

./gimp/app/dialogs/tips-dialog.c:              tip = gimp_tip_new (_("<b>Your GIMP tips file appears to be missing!</b>"),
./gimp/app/dialogs/tips-dialog.c:              tip = gimp_tip_new (_("<b>The GIMP tips file could not be parsed!</b>"),


I'll attach a patch in a minute to fix this.
Comment 1 Elijah Newren 2006-10-07 18:47:32 UTC 
Created attachment 74234 [details] [review]
Remove markup
Comment 2 Sven Neumann 2006-10-09 13:07:32 UTC 
Thanks for the patch but I have rather changed the internal API to avoid these pointless string duplications.

2006-10-09  Sven Neumann  <sven@gimp.org>

	* app/dialogs/tips-parser.[ch]: accept printf-style format strings.

	* app/dialogs/tips-dialog.c: avoid markup in translatable messages
	(bug #360458).