After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 359165 - marshallers can throw warnings with -Wunused
marshallers can throw warnings with -Wunused
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gobject
2.12.x
Other Linux
: Normal normal
: ---
Assigned To: Sven Herzberg
gtkdev
: 357510 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-10-03 00:39 UTC by Sven Herzberg
Modified: 2007-10-13 10:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Testcase (562 bytes, application/x-bzip)
2006-10-03 00:39 UTC, Sven Herzberg 		  Details
Proposed Patch (929 bytes, patch)
2006-10-03 00:40 UTC, Sven Herzberg 		accepted-commit_now Details | Review

Description Sven Herzberg 2006-10-03 00:39:01 UTC 
see attached testcase
Comment 1 Sven Herzberg 2006-10-03 00:39:31 UTC 
Created attachment 73908 [details]
Testcase
Comment 2 Sven Herzberg 2006-10-03 00:40:26 UTC 
Created attachment 73909 [details] [review]
Proposed Patch
Comment 3 Behdad Esfahbod 2006-10-03 15:48:02 UTC 

*** This bug has been marked as a duplicate of 357510 ***
Comment 4 Tim Janik 2007-06-14 23:44:04 UTC 
*** Bug 357510 has been marked as a duplicate of this bug. ***
Comment 5 Tim Janik 2007-06-14 23:46:22 UTC 
(In reply to comment #2)
> Created an attachment (id=73909) [edit]
> Proposed Patch

thanks, the patch looks good, we don't need the testcase for glib though.
please apply and make sure make check still passes with glib and gtk after application and after deleting all the generated marshaller files before the build (to ensure they actually get rebuilt before make check).
Comment 6 Sven Herzberg 2007-10-13 10:52:13 UTC 
2007-10-13  Sven Herzberg  <herzi@gnome-de.org>

        Reviewed by Tim Janik.

        Created marshallers that don't throw gcc warnings when compiling with
        -WUnused (fixes #359165).

        * gobject/glib-genmarshal.c: decorate return_value and invocation_hint
        with G_GNUC_UNUSED