After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 357948 - Category editor's icon selection file dialog doesn't offer previews
Category editor's icon selection file dialog doesn't offer previews
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Calendar
2.8.x (obsolete)
Other All
: Normal minor
: ---
Assigned To: Milan Crha
Evolution QA team
evolution[categories]
Depends on:
Blocks:
 
 
Reported: 2006-09-27 10:54 UTC by Oded Arbel
Modified: 2008-12-03 11:36 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16

Attachments
proposed eds patch (2.05 KB, patch)
2008-12-02 16:51 UTC, Milan Crha 		committed Details | Review

Description Oded Arbel 2006-09-27 10:54:52 UTC 
This pertains to the file browsing dialog "Category Icon" in the category properties dialog (accessible by entering category selection from a meeting dialog and clicking on "New" or "Edit") - When browsing for an icon, its almost impossible to properly select an icon based only on its file name. It would much more useful to show a preview of the icon currently selected in the browsing dialog.

Other information:
For an example of how this can be done correctly, check the Nautilus folder properties dialog, which allows you to change the icon for a folder using a file browsing dialog identical to the "Category Icon" dialog except that it has a preview of the selected icon. Also compare with KDE's file open dialog which offers a preview option for any operation.
Comment 1 Milan Crha 2008-12-02 16:51:30 UTC 
Created attachment 123809 [details] [review]
proposed eds patch

for evolution-data-server;

This does a preview. It's a bit strange when the icon is small, and it is supposed to be 16x16, it's almost invisible on the right on the right of the file list.

I filled bug #563002 against filechooser because of the initial filling of the preview.
Comment 2 Matthew Barnes 2008-12-02 17:18:05 UTC 
Haven't tested this, but the changes look correct to me.

Test and commit to trunk.
Comment 3 Milan Crha 2008-12-03 11:36:44 UTC 
Committed to trunk. Committed revision 9792.