After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 357800 - [libvisual] doesn't pass audio data to libvisual 0.4.0 correctly
[libvisual] doesn't pass audio data to libvisual 0.4.0 correctly
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.11
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 357988 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-09-26 12:15 UTC by Jonathan Matthew
Modified: 2006-09-28 15:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (4.62 KB, patch)
2006-09-26 12:17 UTC, Jonathan Matthew 		none Details | Review

Description Jonathan Matthew 2006-09-26 12:15:23 UTC 
libvisual 0.4.0 doesn't use the audio->plugpcm array any more, it expects the caller/input plugin to insert data into the samplepool object.
Comment 1 Jonathan Matthew 2006-09-26 12:17:24 UTC 
Created attachment 73425 [details] [review]
patch

valgrind seems fairly happy with this, both with libvisual 0.2 and libvisual 0.4 (with a patch I sent to the libvisual-devel mailing list).
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2006-09-27 11:58:08 UTC 
2006-09-27  Stefan Kost  <ensonic@users.sf.net>

	Patch by: Jonathan Matthew <jonathan@kaolin.wh9.net>

	* ext/libvisual/visual.c: (gst_visual_clear_actors),
	(gst_visual_chain), (gst_visual_change_state):
	  Libvisual plugin was not passing audio data to libvisual 0.4.0 
	  correctly. Fixes #357800
Comment 3 Tim-Philipp Müller 2006-09-28 15:44:52 UTC 
*** Bug 357988 has been marked as a duplicate of this bug. ***