GNOME Bugzilla – Bug 357244
Fix white space bugs
Last modified: 2006-10-06 20:06:13 UTC
There is lots of white space bugs that can be solved with a little script.
Created attachment 73248 [details] a python script to redo the indentation This script replace 8 spaces for indentation by a tab and removes white spaces in the end of lines.
Hum the patch generated thanks to the script is ~36000 lines long and takes 1M. Bugzilla refuse to attach that kind of files... I uploaded it there: http://users.skynet.be/Zdra/gossip-indent.patch
This is not really "handleable" with patches, they get out of sync too quickly (already doesn't apply anymore). Committing this now will probably break the outstanding patches too... like the account changes. It's better to handle this kind of thing when things are slow or on a per-file basis when doing other changes. Emacs can do it, that's what I usually use. Maybe you can redo the patch after the account patch has been committed? And after that we should try to keep the whitespace consistent.
Created attachment 73262 [details] more automated Here is an improved script. It does the same but automatically redo all files of gossip. Just start the script in gossip's root directory and commit the changes. Like that you can commit this big change when there is no patch pending on bugzilla.
Nice scripts. Richard is right, it would break outstanding patches. We can perhaps use this later when we have less patches waiting to go in to CVS. Xavier, this script looks quite handy. I am planning on releasing a python script I have been writing to handle maintainer operations, i.e. getting a list of bug fixes from the ChangeLog and getting their summary from Bugzilla (and using that to produce the mail we send out). Would you be ok with me using this python code? This seems like another maintainer-type tool which could be useful.
Martyn > of course you do what you want with this script. Consider it under GPL ;-)
Created attachment 73274 [details] spaces before a tab are invisible If there is less than 8 spaces before a tab those spaces are invisible and should be added.
Ah nice! I was going to ask if you could make it run over all the files :D
Martyn, did you just use this script and make a big commit? It's going to make merging changes from HEAD into the TELEPATHY branch a bit harder. Oh well :P We won't have to go through many more of those anyway.
Closelyose.