After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 356670 - Support for per application secrets
Support for per application secrets
Status: RESOLVED FIXED
Product: gnome-keyring
Classification: Core
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: Stef Walter
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2006-09-19 03:03 UTC by Stef Walter
Modified: 2006-11-05 01:18 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
Adds support for application-only secrets (7.48 KB, patch)
2006-09-19 03:06 UTC, Stef Walter
committed Details | Review

Description Stef Walter 2006-09-19 03:03:30 UTC
Certain applications wish to have secrets that only their application (and perhaps other ACLs added by that application) can access. Epiphany for example. See bug #356298 for discussion.

This adds a new type of secret: GNOME_KEYRING_ITEM_APPLICATION_SECRET

When created with this item type, the item is not listed, or accessible in any way for other applications.

Other approaches were tried out (such as a special ACL that denoted 'application private') but each had its flaws. This approach seems to make the most sense for the user and for the applications involved.
Comment 1 Stef Walter 2006-09-19 03:06:57 UTC
Created attachment 73010 [details] [review]
Adds support for application-only secrets

Also included are some tests for this feature. In particular the following demonstrates that it works:

# Create application only item
./test-keyring A ApplicationItem appitem

# Show the item 
./test-keyring i <keyring> <ID>

# Try to access with another application
./test-keyring-two i <keyring> <ID> 

# Try to list with another application
./test-keyring-two I
Comment 2 Stef Walter 2006-11-05 01:18:07 UTC
Committed. Changed the code a little whereby GNOME_KEYRING_ITEM_APPLICATION_SECRET is a modifier to the other item types rather than an item type in its own right. 

2006-10-04  Nate Nielsen  <nielsen@memberwebs.com>

   	* Makefile.am:
	* gnome-keyring-daemon.c (request_allowed_for_app, op_list_items_execute,
	op_create_item_collect, op_create_item_execute, op_set_item_info_execute,
	op_find_execute, op_find_collect, schedule_ask): 
	* gnome-keyring.h:
	* test.c: Add ability to mark an item as 'application only' whereby only 
	applications on the ACL will ever get access to the data. See bug #356670