After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 356186 - Comboboxes not navigated well during review
Comboboxes not navigated well during review
Status: RESOLVED FIXED
Product: lsr
Classification: Deprecated
Component: core
0.2.x
Other Linux
: High normal
: 0.4.0
Assigned To: LSR maintainers
LSR maintainers
Depends on:
Blocks:
 
 
Reported: 2006-09-15 21:15 UTC by Peter Parente
Modified: 2006-12-21 21:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch for combobox navigation improvement (8.52 KB, patch)
2006-12-19 20:28 UTC, Scott Haeger
none Details | Review

Description Peter Parente 2006-09-15 21:15:46 UTC
The widgets under a combobox should be treated as a group during navigation, not as individual elements. The ComboboxAdapter.py file should grow an adapter class for navigation to improve this case.
Comment 1 Peter Parente 2006-12-08 21:15:11 UTC
This adapter should implement IAccessibleNav and IItemNav. Visible navigation over a closed combobox should just include the currently selected item, not the list items and never the button. Visible navigation over an open combobox should include the visible items in the list popup too, but never the button. When invisible items should also be counted (only_visible=False), the list items should always be traversed, even when hidden. Again, the button should not be reported.

If possible, I'd like to have the list items in a combobox treated as numeric item_offsets in a POR refering to the combobox. That is:

* POR(combobox accessible, None, 0) is the combobox widget with the active selection showing
* POR(combobox accessible, 0, 0) is the first available item in the combobox list
* POR(combobox accessible, 1, 0) is the second available item in the combobox list
etc.
Comment 2 Scott Haeger 2006-12-19 20:26:55 UTC
Combobox items can appear at almost any level under a combobox widget.  Current implementation does a depth only search looking for a "list" or "menu" item.  The combobox items, ususally "list item" or "menu item", appear as children of these nodes.  Other nodes may need to be added to the search list if the need arises.   
Comment 3 Scott Haeger 2006-12-19 20:28:22 UTC
Created attachment 78650 [details] [review]
patch for combobox navigation improvement
Comment 4 Peter Parente 2006-12-21 21:01:43 UTC
Fixed in the development version. The fix will be available in the next major release. Thank you for your bug report.