After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 355085 - Gnome-sound-recorder dialog too small
Gnome-sound-recorder dialog too small
Status: RESOLVED FIXED
Product: gnome-media
Classification: Deprecated
Component: Gnome-Sound-Recorder
2.16.x
Other Linux
: Normal normal
: 2.17.4
Assigned To: gnome media maintainers
gnome media maintainers
: 383080 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-09-09 10:00 UTC by Martin Bergner
Modified: 2007-01-08 00:37 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
screenshot (21.98 KB, image/png)
2007-01-06 19:09 UTC, Ronald Bultje
Details
Screenshot of modification in German interface (33.21 KB, image/png)
2007-01-07 18:08 UTC, Shane Handley
Details

Description Martin Bergner 2006-09-09 10:00:39 UTC
Whenever I start gnome-sound-recorder, I find,that the dialog is to small for the following reason:

When you open the application, you see the record button, which you will press if you want to record something. If you then want to stop the recording, you don't see the stop button and you have to resize the dialog, which causes you to record more, than you wanted. 

I see two possible fixes for this:

1. make the record button to become a "Stop" button after pressed
2. enforce a minimum dialog size at start

I will attach a patch to realize the second approach, since it's a lot easier ;)
Comment 1 Martin Bergner 2006-09-09 10:04:01 UTC
As usual, when clicking commit, you see that there is more to it than you thought.
Of course, it's locale specific, well at least for German, 605 pixels wide is the minimum.

I guess that makes the whole thing more difficult :)
Comment 2 Ronald Bultje 2007-01-06 19:09:21 UTC
Created attachment 79551 [details]
screenshot

It works here, can you attach a screenshot so I see the problem?
Comment 3 Ronald Bultje 2007-01-06 19:49:08 UTC
*** Bug 383080 has been marked as a duplicate of this bug. ***
Comment 4 Ronald Bultje 2007-01-06 19:49:51 UTC
#383080 actually contains an image already, so nevermind. I'll see if this is fixeable.
Comment 5 Baptiste Mille-Mathias 2007-01-06 19:52:39 UTC
Comment on attachment 79551 [details]
screenshot

Change the mime :)
Comment 6 Ronald Bultje 2007-01-06 20:36:22 UTC
Comment on attachment 79551 [details]
screenshot

change mime
Comment 7 Shane Handley 2007-01-07 14:45:13 UTC
Just a suggestion, but I don't think that "Save As" demands that kind of toolbar real estate.

It's especially large in German and French, probably other languages as well; removal might help avoid this. The functionality is predictably available via the File menu.
Comment 8 Shane Handley 2007-01-07 15:18:32 UTC
The proposed solution to the following bug may also aid here:

http://bugzilla.gnome.org/show_bug.cgi?id=387400 
Comment 9 Ronald Bultje 2007-01-07 16:37:52 UTC
I want to make several changes. Removing new is fine with me, but save should behave as save-as if no filename has been entered yet (like any other app), thus indeed removing save-as from the toolbar, and I also really want record and play to be substituted by stop, rather than becoing insensitive. This together should fix this (although the theoretical problem will continue to exist).

anyway, I don't have any of this done yet. :-). I should hurry, freeze is tomorrow.
Comment 10 Ronald Bultje 2007-01-07 17:30:38 UTC
2007-01-07  Ronald S. Bultje,,,  <rbultje@gnome.org>

        * grecord/src/gsr-window.c: (pipeline_error_cb), (file_save_cb),
        (play_state_changed_cb), (record_state_changed_cb),
        (gsr_window_set_property):
        * grecord/src/ui.xml:
          Remove save-as from toolbar, make save behave as save-as if no
          filename has been given yet.

OK, so the stop/play/record idea didn't work out, it makes the toolbar reposition buttons as they become visible or not, which is highly annoying, so I just removed save-as. This bug should now be fixed.
Comment 11 Shane Handley 2007-01-07 18:08:36 UTC
Created attachment 79658 [details]
Screenshot of modification in German interface

Screenshot confirmation that Ronald's fix does indeed resolve this issue (German, w/ size 10 font, but also in French).

Wanted to be sure (anal), thought i'd share.
Comment 12 Jean-François Fortin Tam 2007-01-07 21:49:27 UTC
Hmm wait, I just saw in Glade that there is a toolbar property that governs wether icons can expand or be hidden into an arrow:

<property name="show_arrow">False</property>

This would prevent the toolbar from overflowing into an arrow, and would resize the window's width instead. What about that?
Comment 13 Ronald Bultje 2007-01-07 21:52:40 UTC
Sounds good, can you apply that patch yourself?
Comment 14 Jean-François Fortin Tam 2007-01-07 23:28:49 UTC
Hmm unfortunately no, I'm not a developer, just a user interface freak that plays with glade to do mockups :)
Comment 15 Ronald Bultje 2007-01-07 23:34:11 UTC
Let me reopen this so I remember to apply this when I get home tonight.
Comment 16 Ronald Bultje 2007-01-08 00:37:28 UTC
2007-01-07  Ronald S. Bultje,,,  <rbultje@gnome.org>

        * grecord/src/gsr-window.c: (gsr_window_init):
          Set show_arrow to FALSE, so that the toolbar cannot be hidden
          when the text of the labels is too large. Idea provided by
          Jeff Fortin <nekohayo@gmail.com> (#355085).