After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 353122 - gst_element_get_bus refs the bus unconditionally
gst_element_get_bus refs the bus unconditionally
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.10.10
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-08-27 18:23 UTC by Torsten Schoenfeld
Modified: 2006-08-28 08:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Check for NULL before ref-ing (616 bytes, patch)
2006-08-27 18:25 UTC, Torsten Schoenfeld 		committed Details | Review

Description Torsten Schoenfeld 2006-08-27 18:23:41 UTC 
Apparently, gst_element_get_bus can return NULL but refs the bus unconditionally, which leads to an assertion.  Patch attached.
Comment 1 Torsten Schoenfeld 2006-08-27 18:25:30 UTC 
Created attachment 71711 [details] [review]
Check for NULL before ref-ing
Comment 2 Wim Taymans 2006-08-28 08:41:23 UTC 
        Patch by: Torsten Schoenfeld <kaffeetisch at gmx dot de>

        * gst/gstelement.c: (gst_element_get_bus):
        * tests/check/gst/gstelement.c: (GST_START_TEST):
        Check for NULL before _reffing the bus. Fixes #353122.