GNOME Bugzilla – Bug 353056
Delete From Drive should place photos in the Garbage Bin
Last modified: 2007-12-10 11:37:25 UTC
Instead of removing the photos permanently f-spot should place deleted photos in the garbage bin when performing the "Delete From Drive" command. The command should also be renamed to "Move to Garbage Bin". The metadata in the catalog should only be deleted when the Garbage Bin is emptied.
I like this idea, especially since I do not want to loose any photos by misstake. This could be implemented by adding a garbagebin table, and just adding the photo id to this one when deleting from disk (Move to Garbage Bin). Removing from catalog can still be as it is. The filter for photos should work just as DateRange filter. If photoid (in or not in) garbagebin table depending if Garbage Bin is selected or not.... Then you need the following menues 1) "file-> Empty Garbagebin (xxx photos)" menu (confirm popup) 2) "view-> Garbagebin (xxx photos)" (Check box)
I was thinking that it should move the photos to the Gnome Garbage Bin and that F-Spot should register as a listener for "empty Garbage Bin" events from Nautilus or whoever it is who handles garbage removal. F-Spot would also have to check at startup to see if the photos it has placed in the garbage bin have been recycled, and if so remove their metadata.
Fancy :) If we can get this working that would be neat. Still, we need a separate table for the photos that has been placed in the Garbage Bin, and filter them from the listing, since otherwise the thumbnails will show up. Can you listen to a "Restore" events for one file only? I user deletes 10 photos, and then regrets, and restores 2 of those? Also, F-Spot would also have to check if a photo is missing from the Garbage Bin, and determine if it has been purged, or if it has been restored. (seems easier, but perhaps not from a user's point of view, to implement as I suggested in comment #1)
I just read that F-Spot is supposed to save all metadata in the photo as well as in the catalogue. If that is the case you can just move the photo to the Garbage Bin and remove the photo from the catalogue. To restore the photo all the user has to do is to drag it from the Garbage Bin to F-Spot.
Ok, I need some pills to clear my brain :) Totally agree with you. Lets not over complicate the matter. So, to summarise: Delete from Drive should put the photo into the Garbage Bin, and normal gnome operation should delete it permanently...
I just noticed that Ubuntu had been kind enough to set my locale to Australian English. What I called the Garbage Bin should be called Trash instead.
I vote for this !
I also vote for this. Raise it as a goal? I think it's important to mention the issue of orphaned photos here. If F-Spot simply moves deleted files to the Trash, then there's no need for Remove From Catalog, thus elimenating the orphaned photos issue. Well, maybe there _is_ a need, but the operation Remove From Catalog can be inside the File menu, thus helping to prevent the orphaned photos issue. A popup explaining the issue might be needed for Gnome users.
I am also pretty interested to have move to garbage bin instead of delete from drive. A mistake is always possible, and it is nice to be able to recover from it. Second, a short-cut button for this operation shall be set (perhaps there is one, but I did not find it). IMHO, a Shift+Delete should do it :-) PS: I'm still using F-Spot 0.2.1 so perhaps the move to garbage bin and the short-cut are already implemented...
Dup of http://bugzilla.gnome.org/show_bug.cgi?id=417500 ?
y, please keep the discussion on a single thread *** This bug has been marked as a duplicate of 417500 ***