After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 352293 - Remove copy_of_gdk_x11_window_set_user_time from metacity/src/metacity-dialog.c
Remove copy_of_gdk_x11_window_set_user_time from metacity/src/metacity-dialog.c
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
trunk
Other Linux
: Normal trivial
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks:
 
 
Reported: 2006-08-21 19:19 UTC by Elijah Newren
Modified: 2006-09-07 22:57 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16

Attachments
using gdk_x11_window_set_user_time instead its copy (1.94 KB, patch)
2006-09-01 03:42 UTC, Bruno Boaventura 		accepted-commit_after_freeze Details | Review

Description Elijah Newren 2006-08-21 19:19:44 UTC 
We needed to use gdk_x11_window_set_user_time() before gtk+-2.6 was released, so we made an internal copy, called copy_of_gdk_x11_window_set_user_time().  We should remove the internal copy.  Would be a good project for someone new.
Comment 1 Bruno Boaventura 2006-09-01 03:27:08 UTC 
Elijah,

I want to "kill" this bug. What can I do? How to start?

Bruno
Comment 2 Bruno Boaventura 2006-09-01 03:42:38 UTC 
Created attachment 72004 [details] [review]
using gdk_x11_window_set_user_time instead its copy

I think that is all... Am I right?
Comment 3 Elijah Newren 2006-09-01 03:44:31 UTC 
Yep, looks good.  We can apply it after hard code freeze is over.  Thanks.  :)
Comment 4 Elijah Newren 2006-09-07 22:57:40 UTC 
2006-09-07  Elijah Newren  <newren gmail com>

	* src/metacity-dialog.c: Patch from Bruno Boaventura de Oliveira
	Lacerda to replace copy_of_gdk_x11_window_set_user_time() with
	gdk_x11_window_set_user_time().  We've long since adopted gtk+ >=
	2.6 as a dependency.  #352293