After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 352274 - Location of G_GNUC_INTERNAL breaks Solaris build
Location of G_GNUC_INTERNAL breaks Solaris build
Status: RESOLVED FIXED
Product: libgnomeui
Classification: Deprecated
Component: general
2.15.x
Other Solaris
: Normal normal
: future
Assigned To: libgnomeui maintainers
libgnomeui maintainers
Depends on:
Blocks:
 
 
Reported: 2006-08-21 17:12 UTC by Damien Carbery
Modified: 2006-08-25 13:32 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16

Attachments
Move G_GNUC_INTERNAL to the start of the line. (882 bytes, patch)
2006-08-21 17:13 UTC, Damien Carbery 		none Details | Review

Description Damien Carbery 2006-08-21 17:12:37 UTC 
libgnomeui uses the G_GNUC_INTERNAL macro. There are 2 instances where it is at the end of the line. For the Solaris forte compiler this must be placed at the start of the line. In other instances it is at the start of the line.

Can you please apply the attached patch - it moves the macro in the 2 instances.
This will not affect gcc - it does not care where the macro is placed.

You may want to consider using a private macro like cairo did.
See also 350606 (gtk-engines) and 352981 (glib).
350606 has a link to the cairo change where they resolved this issue with a
private macro.
Comment 1 Damien Carbery 2006-08-21 17:13:13 UTC 
Created attachment 71324 [details] [review]
Move G_GNUC_INTERNAL to the start of the line.
Comment 2 Kjartan Maraas 2006-08-25 13:32:25 UTC 
Commited. Thanks.