Created attachment 71298 [details] [review]
patch for leaks

Created attachment 71299 [details] [review]
updated patch

This one actually compiles...

Commited.

What's the point of filing a bug if you're just going to commit the patch anyway, and not give the maintainer time to even look at it? :)

fcrozat saw some double free crashes from libbackground in todays nautilus release. Might be related to this.

I've reverted this patch for now. Leaking a couple K is better than crashing. Although, looking at the patch, I don't see why it would crash exactly. Anyway, I'm reopening this.

*** Bug 352279 has been marked as a duplicate of this bug. ***

Yeah. There wasn't actually a leak here. The gconf string value was being freed by the method it is being passed to, and Kjartan's patch introduced a double free case. The code does need to be cleaned up though.

Sorry for causing problems here. I didn't check whether the other function freed the strings. I agree that the code needs cleaning up though :-)

Created attachment 71368 [details] [review]
updated patch

I made the read_orientation_from_string() and read_wptype_from_string() behave like read_color_from_string() and adjusted all callers. I think this should work, but I haven't tested it yet

This one looks good to me, please make double sure it works correctly before committing.

Compiled both control-center and nautilus with this and it works. Tried logging in, changing backgrounds etc with no problems. Commited.