GNOME Bugzilla – Bug 352111
no function Pango::LayoutIter wrap(PangoLayoutIter*, bool)
Last modified: 2011-05-31 13:44:25 UTC
Similar to most other Pango:: classes, there should be a function Pango::LayoutIter wrap(PangoLayoutIter* object, bool take_object) Other information: Are there more such functions missing?
Yes, it seems that whenever we use _CLASS_GENERIC in the .hg file, we need to write a wrap() function by hand. For instance, we do this in pango/src/attributes.hg. A patch would be welcome. In the meantime, people should be able to use the constructors directly.
Created attachment 76422 [details] [review] Patch: adds wrap() functions for Pango::LayoutIter, some other documentation The patch, besides giving more documentation on Gdk::Drawable, adds the functions Pango::LayoutIter& wrap (PangoLayoutIter *object); const Pango::LayoutIter& wrap (const PangoLayoutIter *object);
I have committed the documentation (which was unrelated, so it should have been in a separate patch), but the API addition must wait until we branch gtkmm. I'm not quite ready to do that yet, but I will commit the patch when I create the branch. Thanks.
Created attachment 87360 [details] [review] pangomm_layoutiter_wrap.patch This the remaining part of the patch. However, it differs to Pango::Attributes - it does not have the take_copy bool. I'd like to add that (adding a suitable constructor) or decide why this one should be different.
Now there is a function Pango::LayoutIter wrap(PangoLayoutIter* object, bool take_copy = false); because _CLASS_GENERIC was replaced by _CLASS_BOXEDTYPE in pangomm/pango/src/layoutiter.hg at 2011-01-08. http://git.gnome.org/browse/pangomm/commit/?id=828501a70f78fe88391944034b4a166a631e3daf
Fixed as a side effect of the transition to _CLASS_BOXEDTYPE.