Created attachment 71037 [details] [review]
wavpackenc-1.diff

Created attachment 71081 [details] [review]
wavpackenc-1.diff

this one also fixes a small memory leak

I think the caps/template should be the other way around: output is framed, so it should be framed=true everywhere really. encoder ! parser ! decoder doesn't work, but that's really more a parser problem (which should probably accept both framed and unframed input if this is supposed to work; if we do change wavpackparse, we need to mess with the ranks though to make sure autoplugging still works right); however, I don't really think it's important that this works, encoder ! decoder workiness is enough IMHO.

  2006-08-21  Tim-Philipp Müller  <tim at centricular dot net>

        * ext/wavpack/gstwavpackenc.c: (gst_wavpack_enc_init),
        (gst_wavpack_enc_set_wp_config), (gst_wavpack_enc_push_block),
        (gst_wavpack_enc_chain), (gst_wavpack_enc_rewrite_first_block),
        (gst_wavpack_enc_sink_event):
          Fix caps set on buffers and template caps (output is framed)
          and make them match (#351663); use GST_WARNING_OBJECT instead of
          GST_ELEMENT_WARNING; simplify push_block(); do some small
          clean-ups here and there; fix memleak (#351663).

Works fine here... thanks :)