After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 351661 - crash when opening launcher properties
crash when opening launcher properties
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: general
2.15.x
Other Linux
: Normal critical
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-08-16 19:33 UTC by Jens Granseuer
Modified: 2006-08-18 10:17 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16

Attachments
don't cause a critical warning in glib (558 bytes, patch)
2006-08-16 19:34 UTC, Jens Granseuer 		committed Details | Review

Description Jens Granseuer 2006-08-16 19:33:38 UTC 
I had a launcher with a themed icon on the panel. Then I uninstalled the package which contained the icon. The panel displays the GNOME foot. That's no good so I want to change the icon, right-click to get to the launcher properties and boom!

The problem resides in panel-ditem-edit.c (panel_ditem_editor_sync_display).
When determining the icon, only buffer is checked for NULL, however tmpstr can become NULL, too, and g_path_get_dirname() throws a CRITICAL in that case.

Fix attached which fixes the crash for me.
Comment 1 Jens Granseuer 2006-08-16 19:34:25 UTC 
Created attachment 71036 [details] [review]
don't cause a critical warning in glib
Comment 2 Jens Granseuer 2006-08-18 09:41:55 UTC 
This is in 2.15.91, btw.
Comment 3 Vincent Untz 2006-08-18 10:17:44 UTC 
Thanks.