GNOME Bugzilla – Bug 351577
GNKSA: cancel & supersede
Last modified: 2006-08-22 18:08:40 UTC
the rewrite fails GNKSA rule 13 in that it doesn't support cancel or supersede. We can test to see if the user owns the post by comparing the From: header to the posting profiles, as we did before. 13) Allow users to both cancel and supersede their own articles (and _no_ others!) Any software that posts news SHOULD provide a command that the user can invoke to cancel her own articles. It SHOULD also provide the option to supersede the user's own articles. The software MUST guarantee that the user cannot cancel or supersede other people's articles, as far as possible. Caveat: since completely reliable authentication can be infeasible, the best the software can do is to make a good-faith effort to determine whether or not cancelling or superseding is valid: i.e. by trusting upon its user configuration and checking it against the relevant header(s) in the target article. If the software uses the English language, the text of the cancel command SHOULD include the word "cancel", rather than non-standard verbs such as "delete". Similarly, in English software, the text of the supersede command SHOULD include the word "supersede". Rationale: People make mistakes and need the ability to revoke or correct them; both `cancel' and `supersede' exist for good reasons. However, software should not encourage users to abuse the net, either intentionally or accidentally, by sending unauthorized (`rogue') cancels or supersedes. The supersede option is essential: due (a.o.) to sometimes unpredictable usenet propagation, a "cancel-cum-repost" may behave very different from a "supersede". News servers might also have different acceptance policies for both.
*** Bug 351579 has been marked as a duplicate of this bug. ***
*** Bug 324795 has been marked as a duplicate of this bug. ***
Created attachment 71108 [details] [review] 0.108 patch -- first draft.
From what I can tell, this patch isn't really optimal: The lines: - GMimeMessage* create_followup (); + GMimeMessage* create_followup_or_reply (bool is_reply); Dont really appear to make sense, since the method create_followup_or_reply doesn't appear to be implemented anywhere. Lines like these: + HIG :: message_dialog_set_text (GTK_MESSAGE_DIALOG(w), + _("Unable to supersede article."), + _("The article doesn't match any of your posting profiles.")); Don't appear to make sense either, as the HIG struct doesn't include a method called message_dialog_set_text. Please correct me if I am wrong.
Yes, I would agree: patches that don't compile are non-optimal. :) Here comes a more complete patch...
Created attachment 71154 [details] [review] 0.108 patch -- second draft.
This draft fix is included in 0.109.