After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 351301 - 0.108 doesn't build with gtk+ < 2.6
0.108 doesn't build with gtk+ < 2.6
Status: RESOLVED FIXED
Product: Pan
Classification: Other
Component: general
pre-1.0 betas
Other Linux
: Normal normal
: 1.0
Assigned To: Charles Kerr
Pan QA Team
Depends on:
Blocks:
 
 
Reported: 2006-08-14 14:28 UTC by Charles Kerr
Modified: 2006-08-14 21:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0.108 patch to fix the root problem (9.17 KB, patch)
2006-08-14 16:08 UTC, Charles Kerr 		none Details | Review

Description Charles Kerr 2006-08-14 14:28:42 UTC 
The call to gtk_text_view_get_iter_at_position in body-pane.cc
makes Pan unable to build for desktops with gtk+ < 2.6.
Comment 1 Charles Kerr 2006-08-14 16:06:04 UTC 
Looking closer, IMO we're using _at_position to work around a bug in how
we handle pixmap detection at the current mouse location.  We should handle
it more like we do url detection.

url detection is straightforward -- just ask the text buffer if the iter under
the mouse is inside a 'url' tag region.

pixbuf detection is more complicated for no good reason.
We back up a character and see if we're at the beginning of a pixbuf region.

Since both detection routines use our get_iter_at_pos() function, and one
wants the actual pos and the other wants to back up a space for no good
reason, IMO we should just fix the pixbuf detection code and throw away
the code that backs up a space.
Comment 2 Charles Kerr 2006-08-14 16:08:14 UTC 
Created attachment 70869 [details] [review]
0.108 patch to fix the root problem