After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 350900 - [adder] should not clamp floating point values
[adder] should not clamp floating point values
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal normal
: 0.10.10
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-08-11 14:31 UTC by René Stadler
Modified: 2006-08-11 15:58 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description René Stadler 2006-08-11 14:31:57 UTC
Currently, the adder element clamps sample values of floating point formats to the range [-1.0; 1.0] (-0dB).  This is incorrect: It might be perfectly possible to handle values exceeding -0dB in the pipeline.  Most probably by using a compressor/limiter element of choice, which would give a more desired result than just clipping, as it is currently done (implicitely).  If application developers do indeed just want to let it clip, the audioconvert element will just do it as part of the conversion to an integer format.  In no way should the adder element do the clipping on its own.
Comment 1 Wim Taymans 2006-08-11 15:58:19 UTC
Very good point, fixed in CVS:

        * gst/adder/gstadder.c:
        Don't clip float values. Fixes #350900.