GNOME Bugzilla – Bug 350323
Filter by "Mailing list contains" requires "@" symbol
Last modified: 2013-03-12 17:10:42 UTC
Please describe the problem: When creating a filter to filter mailing lists, and selecting "Contains" from the second drop-down menu in the rule editor, the rule will not match any messages if the rule text does not contain the @ symbol. Steps to reproduce: 1. Create a filter against the Mailing List header, and select "Contains" from the second drop-down list. 2. Enter the domain name associated with the mailing list (e.g. "securityfocus.com"). 3. Save the list and run it against some messages. Actual results: Messages originating from the specified mailing list are not filtered. Expected results: Messages from the specified list (or in this case, all lists from securityfocus.com) should be filtered as defined in the filter. Does this happen every time? Yes. Other information: Changing the filter text to "@securityfocus.com" causes the messages to be filtered as normal. I can see it being very easy for a user to simply type the domain name of their mailing lists without the @ symbol and not realise why it's not working.
it's not actually even supposed to be hand-edited, the value is auto-generated via a regex on the message headers and it's gotta match that regex extracted token or it won't necessarily work.
Created attachment 238717 [details] [review] eds patch for evolution-data-server; From the code above this change: /* Special mailing list old-version domain hack. * If one of the mailing list names doesn't have an @ in it, * its old-style, so only match against the pre-domain part, * which should be common. */ This was trying to be too smart, I'd say. I removed the part where the list address had been stripped by the '@' domain when the user-entered value didn't contain domain part. The other way around, when user has set the domain, and the server doesn't provide it for any reason, can be used, thus only the pre-@ part is compared.
Created commit 6c66bb8 in eds master (3.7.92+)