After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 350145 - GtkRecent is not screen safe
GtkRecent is not screen safe
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-08-06 11:49 UTC by Nickolay V. Shmyrev
Modified: 2006-08-11 11:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (1.82 KB, patch)
2006-08-06 16:13 UTC, Carlos Garcia Campos
none Details | Review

Description Nickolay V. Shmyrev 2006-08-06 11:49:49 UTC
(15:07:15) pbor: nsh: btw, from a glance evince gtk-recent patch is not multiscreen safe
(15:07:16) asabil: even by evind
(15:07:26) asabil: oh
(15:07:32) asabil: maybe that's the reason
(15:07:34) pbor: asabil: you mean .recently-used.xbel right?
(15:07:42) asabil: nop
(15:07:48) asabil: .recently-used
(15:07:56) pbor: asabil: gtkrecent uses .recently-used.xbel
(15:08:04) nsh: pbor: what is multiscreen-safe? I thought we run single instanse of evince
(15:08:06) pbor: asabil: .recently-used is EggRecent
(15:08:06) asabil: oh
(15:08:08) asabil: yep
(15:08:11) asabil: .xbel too
(15:08:18) nsh: pbor: new file is my largest complain
(15:08:21) asabil: .recently-used.xbel yes
(15:08:39) asabil: and only gedit has an entry
(15:08:48) pbor: nsh: exactly, since evince is single instance it can have windows on different screens
(15:08:52) asabil: i am running gnome cvs inside an Xnest
(15:09:11) pbor: nsh: if a screen is closed the gtk_recent_manager goes away
(15:09:26) nsh: oh no
(15:09:44) pbor: nsh: thus you should use gtk_recent_manager_get_for_screen() instead of get_default()
(15:09:58) pbor: and connect to the screen-changed signal
(15:10:23) nsh: Heh
(15:10:31) nsh: I'll file bug about that
Comment 1 Carlos Garcia Campos 2006-08-06 16:13:10 UTC
Created attachment 70321 [details] [review]
Patch

Here is a patch. It would be nice if someone could confirm that this patch fixes the problem.
Comment 2 Nickolay V. Shmyrev 2006-08-11 05:45:13 UTC
Heh, I wonder if any of us have several screens. I think we should just commit the patch.
Comment 3 Carlos Garcia Campos 2006-08-11 11:42:36 UTC
No, this patch is wrong. I've just committed a new patch that I think is correct.